review changes

Author: Crabzmatic

src/Microsoft.ML.AutoML/Utils/StringEditDistance.cs

@@ -2,9 +2,9 @@
 
 namespace Microsoft.ML.AutoML.Utils
 {
-    public static class StringEditDistance
+    internal static class StringEditDistance
     {
-        public static int GetEditDistance(string first, string second)
+        public static int GetLevenshteinDistance(string first, string second)
         {
             if (first is null)
             {

src/Microsoft.ML.AutoML/Utils/UserInputValidationUtil.cs

@@ -249,12 +249,15 @@ private static void ValidateTrainDataColumn(IDataView trainData, string columnNa
             var nullableColumn = trainData.Schema.GetColumnOrNull(columnName);
             if (nullableColumn == null)
             {
-                var closestNamed = ClosestNamed(trainData, columnName, 2);
+                var closestNamed = ClosestNamed(trainData, columnName, 7);
+
+                var exceptionMessage = $"Provided {columnPurpose} column '{columnName}' not found in training data.";
                 if (closestNamed != string.Empty)
                 {
-                    throw new ArgumentException($"Provided {columnPurpose} column '{columnName}' not found in training data. Did you mean '{closestNamed}'.");
+                    exceptionMessage += $" Did you mean '{closestNamed}'.";
                 }
-                throw new ArgumentException($"Provided {columnPurpose} column '{columnName}' not found in training data.");
+
+                throw new ArgumentException(exceptionMessage);
             }
 
             if(allowedTypes == null)
@@ -284,7 +287,7 @@ private static string ClosestNamed(IDataView trainData, string columnName, int m
             var closestNamed = string.Empty;
             foreach (var column in trainData.Schema)
             {
-                var editDistance = StringEditDistance.GetEditDistance(column.Name, columnName);
+                var editDistance = StringEditDistance.GetLevenshteinDistance(column.Name, columnName);
                 if (editDistance < minEditDistance)
                 {
                     minEditDistance = editDistance;

test/Microsoft.ML.AutoML.Tests/UserInputValidationTests.cs

@@ -44,10 +44,11 @@ public void ValidateExperimentExecuteLabelNotInTrain()
         {
             foreach (var task in new[] { TaskKind.Recommendation, TaskKind.Regression, TaskKind.Ranking })
             {
+                const string columnName = "ReallyLongNonExistingColumnName";
                 var ex = Assert.Throws<ArgumentException>(() => UserInputValidationUtil.ValidateExperimentExecuteArgs(_data,
-                new ColumnInformation() { LabelColumnName = "L" }, null, task));
+                new ColumnInformation() { LabelColumnName = columnName }, null, task));
 
-                Assert.Equal("Provided label column 'L' not found in training data.", ex.Message);
+                Assert.Equal($"Provided label column '{columnName}' not found in training data.", ex.Message);
             }
         }