Internalize IDataTransform (#2509)

Author: Ivanidzo4ka

src/Microsoft.ML.Data/DataView/RowToRowMapperTransform.cs

@@ -56,15 +56,16 @@ internal interface IRowMapper : ICanSaveModel
         /// </summary>
         ITransformer GetTransformer();
     }
-
-    public delegate void SignatureLoadRowMapper(ModelLoadContext ctx, Schema schema);
+    [BestFriend]
+    internal delegate void SignatureLoadRowMapper(ModelLoadContext ctx, Schema schema);
 
     /// <summary>
     /// This class is a transform that can add any number of output columns, that depend on any number of input columns.
     /// It does so with the help of an <see cref="IRowMapper"/>, that is given a schema in its constructor, and has methods
     /// to get the dependencies on input columns and the getters for the output columns, given an active set of output columns.
     /// </summary>
-    public sealed class RowToRowMapperTransform : RowToRowTransformBase, IRowToRowMapper,
+    [BestFriend]
+    internal sealed class RowToRowMapperTransform : RowToRowTransformBase, IRowToRowMapper,
         ITransformCanSaveOnnx, ITransformCanSavePfa, ITransformTemplate
     {
         private readonly IRowMapper _mapper;
@@ -92,8 +93,7 @@ private static VersionInfo GetVersionInfo()
 
         bool ICanSavePfa.CanSavePfa => _mapper is ICanSavePfa pfaMapper ? pfaMapper.CanSavePfa : false;
 
-        [BestFriend]
-        internal RowToRowMapperTransform(IHostEnvironment env, IDataView input, IRowMapper mapper, Func<Schema, IRowMapper> mapperFactory)
+        public RowToRowMapperTransform(IHostEnvironment env, IDataView input, IRowMapper mapper, Func<Schema, IRowMapper> mapperFactory)
             : base(env, RegistrationName, input)
         {
             Contracts.CheckValue(mapper, nameof(mapper));
@@ -103,8 +103,7 @@ internal RowToRowMapperTransform(IHostEnvironment env, IDataView input, IRowMapp
             _bindings = new ColumnBindings(input.Schema, mapper.GetOutputColumns());
         }
 
-        [BestFriend]
-        internal static Schema GetOutputSchema(Schema inputSchema, IRowMapper mapper)
+        public static Schema GetOutputSchema(Schema inputSchema, IRowMapper mapper)
         {
             Contracts.CheckValue(inputSchema, nameof(inputSchema));
             Contracts.CheckValue(mapper, nameof(mapper));

src/Microsoft.ML.Data/Transforms/LabelConvertTransform.cs

@@ -22,7 +22,8 @@
 
 namespace Microsoft.ML.Transforms
 {
-    public sealed class LabelConvertTransform : OneToOneTransformBase
+    [BestFriend]
+    internal sealed class LabelConvertTransform : OneToOneTransformBase
     {
         public sealed class Column : OneToOneColumn
         {

src/Microsoft.ML.Data/Transforms/RowToRowTransformerBase.cs

@@ -47,7 +47,8 @@ public Schema GetOutputSchema(Schema inputSchema)
 
         public IDataView Transform(IDataView input) => MakeDataTransform(input);
 
-        protected RowToRowMapperTransform MakeDataTransform(IDataView input)
+        [BestFriend]
+        private protected RowToRowMapperTransform MakeDataTransform(IDataView input)
         {
             Host.CheckValue(input, nameof(input));
             return new RowToRowMapperTransform(Host, input, MakeRowMapper(input.Schema), MakeRowMapper);

src/Microsoft.ML.Data/Transforms/TransformBase.cs

@@ -18,7 +18,8 @@ namespace Microsoft.ML.Data
     /// <summary>
     /// Base class for transforms.
     /// </summary>
-    public abstract class TransformBase : IDataTransform
+    [BestFriend]
+    internal abstract class TransformBase : IDataTransform
     {
         protected readonly IHost Host;
 
@@ -104,7 +105,8 @@ public RowCursor GetRowCursor(IEnumerable<Schema.Column> columnsNeeded, Random r
     /// <summary>
     /// Base class for transforms that map single input row to single output row.
     /// </summary>
-    public abstract class RowToRowTransformBase : TransformBase
+    [BestFriend]
+    internal abstract class RowToRowTransformBase : TransformBase
     {
         protected RowToRowTransformBase(IHostEnvironment env, string name, IDataView input)
             : base(env, name, input)
@@ -150,7 +152,8 @@ void ISaveAsPfa.SaveAsPfa(BoundPfaContext ctx)
         }
     }
 
-    public abstract class RowToRowMapperTransformBase : RowToRowTransformBase, IRowToRowMapper
+    [BestFriend]
+    internal abstract class RowToRowMapperTransformBase : RowToRowTransformBase, IRowToRowMapper
     {
         protected RowToRowMapperTransformBase(IHostEnvironment env, string name, IDataView input)
             : base(env, name, input)
@@ -244,7 +247,8 @@ public override bool IsColumnActive(int col)
     /// on multiple input columns.
     /// This class provides the implementation of ISchema and IRowCursor.
     /// </summary>
-    public abstract class OneToOneTransformBase : RowToRowMapperTransformBase, ITransposeDataView, ITransformCanSavePfa,
+    [BestFriend]
+    internal abstract class OneToOneTransformBase : RowToRowMapperTransformBase, ITransposeDataView, ITransformCanSavePfa,
         ITransformCanSaveOnnx
     {
         /// <summary>

src/Microsoft.ML.ImageAnalytics/VectorToImageTransform.cs

@@ -27,7 +27,7 @@ namespace Microsoft.ML.ImageAnalytics
     /// <summary>
     /// Transform which takes one or many columns with vectors in them and transform them to <see cref="ImageType"/> representation.
     /// </summary>
-    public sealed class VectorToImageTransform : OneToOneTransformBase
+    internal sealed class VectorToImageTransform : OneToOneTransformBase
     {
         public class Column : OneToOneColumn
         {

src/Microsoft.ML.Transforms/HashJoiningTransform.cs

@@ -31,7 +31,8 @@ namespace Microsoft.ML.Transforms.Conversions
     /// column there is an option to specify which slots should be hashed together into one output slot.
     /// This transform can be applied either to single valued columns or to known length vector columns.
     /// </summary>
-    public sealed class HashJoiningTransform : OneToOneTransformBase
+    [BestFriend]
+    internal sealed class HashJoiningTransform : OneToOneTransformBase
     {
         public const int NumBitsMin = 1;
         public const int NumBitsLim = 32;

src/Microsoft.ML.Transforms/MissingValueIndicatorTransform.cs

@@ -21,7 +21,7 @@
 
 namespace Microsoft.ML.Transforms
 {
-    public sealed class MissingValueIndicatorTransform : OneToOneTransformBase
+    internal sealed class MissingValueIndicatorTransform : OneToOneTransformBase
     {
         public sealed class Column : OneToOneColumn
         {

src/Microsoft.ML.Transforms/Properties/AssemblyInfo.cs

@@ -10,6 +10,7 @@
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Core.Tests" + PublicKey.TestValue)]
 
 [assembly: InternalsVisibleTo(assemblyName: "RunTests" + InternalPublicKey.Value)]
+[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.EntryPoints" + PublicKey.Value)]
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Runtime.NeuralNetworks" + InternalPublicKey.Value)]
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.RServerScoring.NeuralNetworks" + InternalPublicKey.Value)]
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Runtime.TextAnalytics" + InternalPublicKey.Value)]