fix review comments

abgoswam · abgoswam · commit 4cd639766724 · 2019-04-04T00:59:46.000Z
diff --git a/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotEncoding.cs b/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotEncoding.cs
@@ -16,11 +16,11 @@ public static void Example()
             // Get a small dataset as an IEnumerable.
             var samples = new List<DataPoint>()
             {
-                new DataPoint(){ Label = 0, Education = "0-5yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 1, Education = "0-5yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 45, Education = "6-11yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 50, Education = "6-11yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 50, Education = "11-15yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "0-5yrs" },
+                new DataPoint(){ Education = "0-5yrs" },
+                new DataPoint(){ Education = "6-11yrs" },
+                new DataPoint(){ Education = "6-11yrs" },
+                new DataPoint(){ Education = "11-15yrs" },
             };
 
             // Convert training data to IDataView.
@@ -71,11 +71,7 @@ private static void PrintDataColumn(IDataView transformedData, string columnName
         }
         private class DataPoint
         {
-            public float Label { get; set; }
-
             public string Education { get; set; }
-
-            public string ZipCode { get; set; }
         }
     }
 }
diff --git a/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotEncodingMultiColumn.cs b/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotEncodingMultiColumn.cs
@@ -14,11 +14,11 @@ public static void Example()
             // Get a small dataset as an IEnumerable.
             var samples = new List<DataPoint>()
             {
-                new DataPoint(){ Label = 0, Education = "0-5yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 1, Education = "0-5yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 45, Education = "6-11yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 50, Education = "6-11yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 50, Education = "11-15yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "0-5yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "0-5yrs", ZipCode = "98052" },
+                new DataPoint(){ Education = "6-11yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "6-11yrs", ZipCode = "98052" },
+                new DataPoint(){ Education = "11-15yrs", ZipCode = "98005" },
             };
 
             // Convert training data to IDataView.
@@ -49,8 +49,6 @@ public static void Example()
 
         private class DataPoint
         {
-            public float Label { get; set; }
-
             public string Education { get; set; }
 
             public string ZipCode { get; set; }
diff --git a/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotHashEncoding.cs b/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotHashEncoding.cs
@@ -16,11 +16,11 @@ public static void Example()
             // Get a small dataset as an IEnumerable.
             var samples = new List<DataPoint>()
             {
-                new DataPoint(){ Label = 0, Education = "0-5yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 1, Education = "0-5yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 45, Education = "6-11yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 50, Education = "6-11yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 50, Education = "11-15yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "0-5yrs" },
+                new DataPoint(){ Education = "0-5yrs" },
+                new DataPoint(){ Education = "6-11yrs" },
+                new DataPoint(){ Education = "6-11yrs" },
+                new DataPoint(){ Education = "11-15yrs" },
             };
 
             // Convert training data to IDataView.
@@ -77,11 +77,7 @@ private static void PrintDataColumn(IDataView transformedData, string columnName
 
         private class DataPoint
         {
-            public float Label { get; set; }
-
             public string Education { get; set; }
-
-            public string ZipCode { get; set; }
         }
     }
 }
diff --git a/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotHashEncodingMultiColumn.cs b/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Categorical/OneHotHashEncodingMultiColumn.cs
@@ -14,11 +14,11 @@ public static void Example()
             // Get a small dataset as an IEnumerable.
             var samples = new List<DataPoint>()
             {
-                new DataPoint(){ Label = 0, Education = "0-5yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 1, Education = "0-5yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 45, Education = "6-11yrs", ZipCode = "98005" },
-                new DataPoint(){ Label = 50, Education = "6-11yrs", ZipCode = "98052" },
-                new DataPoint(){ Label = 50, Education = "11-15yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "0-5yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "0-5yrs", ZipCode = "98052" },
+                new DataPoint(){ Education = "6-11yrs", ZipCode = "98005" },
+                new DataPoint(){ Education = "6-11yrs", ZipCode = "98052" },
+                new DataPoint(){ Education = "11-15yrs", ZipCode = "98005" },
             };
 
             // Convert training data to IDataView.
@@ -49,8 +49,6 @@ public static void Example()
 
         private class DataPoint
         {
-            public float Label { get; set; }
-
             public string Education { get; set; }
 
             public string ZipCode { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,11 @@ public static void Example()`
`16`	`16`	`// Get a small dataset as an IEnumerable.`
`17`	`17`	`var samples = new List<DataPoint>()`
`18`	`18`	`{`
`19`		`- new DataPoint(){ Label = 0, Education = "0-5yrs", ZipCode = "98005" },`
`20`		`- new DataPoint(){ Label = 1, Education = "0-5yrs", ZipCode = "98052" },`
`21`		`- new DataPoint(){ Label = 45, Education = "6-11yrs", ZipCode = "98005" },`
`22`		`- new DataPoint(){ Label = 50, Education = "6-11yrs", ZipCode = "98052" },`
`23`		`- new DataPoint(){ Label = 50, Education = "11-15yrs", ZipCode = "98005" },`
	`19`	`+ new DataPoint(){ Education = "0-5yrs" },`
	`20`	`+ new DataPoint(){ Education = "0-5yrs" },`
	`21`	`+ new DataPoint(){ Education = "6-11yrs" },`
	`22`	`+ new DataPoint(){ Education = "6-11yrs" },`
	`23`	`+ new DataPoint(){ Education = "11-15yrs" },`
`24`	`24`	`};`
`25`	`25`
`26`	`26`	`// Convert training data to IDataView.`
`@@ -71,11 +71,7 @@ private static void PrintDataColumn(IDataView transformedData, string columnName`
`71`	`71`	`}`
`72`	`72`	`private class DataPoint`
`73`	`73`	`{`
`74`		`- public float Label { get; set; }`
`75`		`-`
`76`	`74`	`public string Education { get; set; }`
`77`		`-`
`78`		`- public string ZipCode { get; set; }`
`79`	`75`	`}`
`80`	`76`	`}`
`81`	`77`	`}`