Replace DateTime with DateTimeOffset

Sparks, Collin · Sparks, Collin · commit 058785533acb · 2018-05-11T16:03:44.000-04:00
DateTime.UtcNow is now DateTimeOffset.Now.UtcDateTime
diff --git a/src/Microsoft.ML.Core/Data/DateTime.cs b/src/Microsoft.ML.Core/Data/DateTime.cs
@@ -74,7 +74,7 @@ public DvDateTime Date
         /// <summary>
         /// Gets a DvDateTime object representing the current UTC date and time.
         /// </summary>
-        public static DvDateTime UtcNow { get { return new DvDateTime(SysDateTime.UtcNow); } }
+        public static DvDateTime UtcNow { get { return new DvDateTime(SysDateTimeOffset.Now.UtcDateTime); } }
 
         public bool IsNA
         {
diff --git a/src/Microsoft.ML.Core/Data/ProgressReporter.cs b/src/Microsoft.ML.Core/Data/ProgressReporter.cs
@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
                     Index = index;
                     Name = name;
                     PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
-                    StartTime = DateTime.UtcNow;
+                    StartTime = DateTimeOffset.Now.UtcDateTime;
                     Channel = channel;
                 }
             }
@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
                 Index = index;
                 Name = name;
                 StartTime = startTime;
-                EventTime = DateTime.UtcNow;
+                EventTime = DateTimeOffset.Now.UtcDateTime;
                 Kind = EventKind.Progress;
                 ProgressEntry = entry;
             }
@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
                 Index = index;
                 Name = name;
                 StartTime = startTime;
-                EventTime = DateTime.UtcNow;
+                EventTime = DateTimeOffset.Now.UtcDateTime;
                 Kind = kind;
                 ProgressEntry = null;
             }
diff --git a/src/Microsoft.ML.Data/Utilities/TimerScope.cs b/src/Microsoft.ML.Data/Utilities/TimerScope.cs
@@ -46,7 +46,7 @@ public void Dispose()
 
             // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
             // Ideally we should change our comparison method to ignore empty lines.
-            _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);
+            _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTimeOffset.Now.UtcDateTime, elapsedSeconds);
 
             using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
             {
diff --git a/src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs b/src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs
@@ -164,7 +164,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)
 
         private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
         {
-            DateTime startTime = DateTime.UtcNow;
+            DateTime startTime = DateTimeOffset.Now.UtcDateTime;
 
             if (maxAllowedFeaturesPerModel < 0)
             {
@@ -450,7 +450,7 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
             // First lambda was infinity; fixing it
             fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));
 
-            TimeSpan duration = DateTime.UtcNow - startTime;
+            TimeSpan duration = DateTimeOffset.Now.UtcDateTime - startTime;
             ch.Info("Elapsed time for compression: {0}", duration);
 
             return fit;
diff --git a/src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs b/src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs
@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,
 
         protected int AppendComments(StringBuilder sb, string trainingParams)
         {
-            sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);
+            sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTimeOffset.Now.UtcDateTime);
 
             string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
             int i = 0;
diff --git a/src/Microsoft.ML.InternalStreams/UnbufferedStream.cs b/src/Microsoft.ML.InternalStreams/UnbufferedStream.cs
@@ -873,11 +873,11 @@ private bool FillBufferPass()
                 {
                     // read into buffer:
                     int readBytes;
-                    //long t = DateTime.UtcNow.Ticks;
+                    //long t = DateTimeOffset.Now.UtcDateTime.Ticks;
                     //long startPos = IOUtil.Win32.Raw.GetFilePos(handle);
                     bool readres = IOUtil.Win32.Raw.ReadFile(_handle, _alignedBuffer[_bufferFillIndex],
                         (int)Math.Min(_blockSize, _alignedLimit - _totalRead), out readBytes);
-                    //t = DateTime.UtcNow.Ticks - t;
+                    //t = DateTimeOffset.Now.UtcDateTime.Ticks - t;
                     //Console.WriteLine("core time: " + (t / (double)TimeSpan.TicksPerSecond).ToString("0.000"));
                     if (!readres)
                     {
diff --git a/src/Microsoft.ML.Maml/MAML.cs b/src/Microsoft.ML.Maml/MAML.cs
@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
                         Path.GetTempPath(),
                         "TLC");
                     var dumpFilePath = Path.Combine(dumpFileDir,
-                        string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
+                        string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTimeOffset.Now.UtcDateTime, Guid.NewGuid()));
                     bool isDumpSaved = false;
                     try
                     {
diff --git a/src/Microsoft.ML.ResultProcessor/ResultProcessor.cs b/src/Microsoft.ML.ResultProcessor/ResultProcessor.cs
@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
                 Results = runResults,
                 PerFoldResults = foldResults,
                 Time = 0,
-                ExecutionDate = DateTime.UtcNow.ToString()
+                ExecutionDate = DateTimeOffset.Now.UtcDateTime.ToString()
             };
         }
 
diff --git a/src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs b/src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs
@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
             Contracts.Assert(Iteration == 0);
             Contracts.Assert(Bias == 0);
 
-            ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
+            ch.Trace("{0} Initializing {1} on {2} features", DateTimeOffset.Now.UtcDateTime, Name, numFeatures);
             NumFeatures = numFeatures;
 
             // We want a dense vector, to prevent memory creation during training
@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
             Iteration++;
             NumIterExamples = 0;
 
-            ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
+            ch.Trace("{0} Starting training iteration {1}", DateTimeOffset.Now.UtcDateTime, Iteration);
             // #if OLD_TRACING // REVIEW: How should this be ported?
             if (Iteration % 20 == 0)
             {
                 Console.Write('.');
                 if (Iteration % 1000 == 0)
-                    Console.WriteLine(" {0}  \t{1}", Iteration, DateTime.UtcNow);
+                    Console.WriteLine(" {0}  \t{1}", Iteration, DateTimeOffset.Now.UtcDateTime);
             }
             // #endif
         }
@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
             Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);
 
             ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
-                DateTime.UtcNow, Iteration, NumIterExamples);
+                DateTimeOffset.Now.UtcDateTime, Iteration, NumIterExamples);
 
             ScaleWeights();
 #if OLD_TRACING // REVIEW: How should this be ported?
@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
                         if (_numIterExamples % 5000000 == 0)
                         {
                             Host.StdOut.Write(" ");
-                            Host.StdOut.Write(DateTime.UtcNow);
+                            Host.StdOut.Write(DateTimeOffset.Now.UtcDateTime);
                         }
                         Host.StdOut.WriteLine();
                     }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public DvDateTime Date`
`74`	`74`	`/// <summary>`
`75`	`75`	`/// Gets a DvDateTime object representing the current UTC date and time.`
`76`	`76`	`/// </summary>`
`77`		`- public static DvDateTime UtcNow { get { return new DvDateTime(SysDateTime.UtcNow); } }`
	`77`	`+ public static DvDateTime UtcNow { get { return new DvDateTime(SysDateTimeOffset.Now.UtcDateTime); } }`
`78`	`78`
`79`	`79`	`public bool IsNA`
`80`	`80`	`{`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public void Dispose()`
`46`	`46`
`47`	`47`	`// REVIEW: This is \n\n is to prevent changes across bunch of baseline files.`
`48`	`48`	`// Ideally we should change our comparison method to ignore empty lines.`
`49`		`- _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);`
	`49`	`+ _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTimeOffset.Now.UtcDateTime, elapsedSeconds);`
`50`	`50`
`51`	`51`	`using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))`
`52`	`52`	`{`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)`
`164`	`164`
`165`	`165`	`private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)`
`166`	`166`	`{`
`167`		`- DateTime startTime = DateTime.UtcNow;`
	`167`	`+ DateTime startTime = DateTimeOffset.Now.UtcDateTime;`
`168`	`168`
`169`	`169`	`if (maxAllowedFeaturesPerModel < 0)`
`170`	`170`	`{`
`@@ -450,7 +450,7 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)`
`450`	`450`	`// First lambda was infinity; fixing it`
`451`	`451`	`fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));`
`452`	`452`
`453`		`- TimeSpan duration = DateTime.UtcNow - startTime;`
	`453`	`+ TimeSpan duration = DateTimeOffset.Now.UtcDateTime - startTime;`
`454`	`454`	`ch.Info("Elapsed time for compression: {0}", duration);`
`455`	`455`
`456`	`456`	`return fit;`
Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,`
`193`	`193`
`194`	`194`	`protected int AppendComments(StringBuilder sb, string trainingParams)`
`195`	`195`	`{`
`196`		`- sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);`
	`196`	`+ sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTimeOffset.Now.UtcDateTime);`
`197`	`197`
`198`	`198`	`string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });`
`199`	`199`	`int i = 0;`
Original file line number	Diff line number	Diff line change
`@@ -873,11 +873,11 @@ private bool FillBufferPass()`
`873`	`873`	`{`
`874`	`874`	`// read into buffer:`
`875`	`875`	`int readBytes;`
`876`		`- //long t = DateTime.UtcNow.Ticks;`
	`876`	`+ //long t = DateTimeOffset.Now.UtcDateTime.Ticks;`
`877`	`877`	`//long startPos = IOUtil.Win32.Raw.GetFilePos(handle);`
`878`	`878`	`bool readres = IOUtil.Win32.Raw.ReadFile(_handle, _alignedBuffer[_bufferFillIndex],`
`879`	`879`	`(int)Math.Min(_blockSize, _alignedLimit - _totalRead), out readBytes);`
`880`		`- //t = DateTime.UtcNow.Ticks - t;`
	`880`	`+ //t = DateTimeOffset.Now.UtcDateTime.Ticks - t;`
`881`	`881`	`//Console.WriteLine("core time: " + (t / (double)TimeSpan.TicksPerSecond).ToString("0.000"));`
`882`	`882`	`if (!readres)`
`883`	`883`	`{`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt`
`145`	`145`	`Path.GetTempPath(),`
`146`	`146`	`"TLC");`
`147`	`147`	`var dumpFilePath = Path.Combine(dumpFileDir,`
`148`		`- string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));`
	`148`	`+ string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTimeOffset.Now.UtcDateTime, Guid.NewGuid()));`
`149`	`149`	`bool isDumpSaved = false;`
`150`	`150`	`try`
`151`	`151`	`{`
Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L`
`584`	`584`	`Results = runResults,`
`585`	`585`	`PerFoldResults = foldResults,`
`586`	`586`	`Time = 0,`
`587`		`- ExecutionDate = DateTime.UtcNow.ToString()`
	`587`	`+ ExecutionDate = DateTimeOffset.Now.UtcDateTime.ToString()`
`588`	`588`	`};`
`589`	`589`	`}`
`590`	`590`