[generator] Fix reserved keywords binary search #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble building Xamarin.Android on my PC because the generated C# code wouldn't compile. The identifiers
checked,decimal, anddelegatewheren't prefixed with@. I later found out that this was happening because Windows on my PC had Region format set to Czech. We have this weird letter "ch" which is actually the 9th letter of our alphabet. Therefore, therequired_keywordsarray isn't sorted correctly when the culture iscs-CZsince it contains the word"checked"andArray.BinarySearchwasn't working correctly for me because it utilized the default culture-specific string comparer. This PR explicitly sets the string comparer for binary search toOrdinalwhich solves the problem.