[generator] Add support for <ns-replace> metadata. #939
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Xml.Linq; | ||
| using Xamarin.Android.Tools; | ||
|
|
||
| namespace Java.Interop.Tools.Generator | ||
| { | ||
| public class NamespaceTransform | ||
|
Contributor
There was a problem hiding this comment. Rando aside: would this be a good use case for C#9
Contributor
There was a problem hiding this comment. Doesn't look like you can override primary constructors (?!), so this isn't a good use case.
Contributor
There was a problem hiding this comment. However, you can still use
Contributor
Author
There was a problem hiding this comment. Reading through the link, I don't see any benefits to using |
||
| { | ||
| public string OldValue { get; } | ||
| public string NewValue { get; } | ||
| public bool IsStartsWith { get; } | ||
| public bool IsEndsWith { get; } | ||
|
|
||
| public NamespaceTransform (string oldValue, string newValue) | ||
| { | ||
| OldValue = oldValue; | ||
| NewValue = newValue; | ||
|
|
||
| if (OldValue.EndsWith (".", StringComparison.Ordinal)) { | ||
jonpryor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| IsStartsWith = true; | ||
| OldValue = OldValue.Substring (0, OldValue.Length - 1); | ||
| } | ||
|
|
||
| if (OldValue.StartsWith (".", StringComparison.Ordinal)) { | ||
| IsEndsWith = true; | ||
| OldValue = OldValue.Substring (1); | ||
| } | ||
| } | ||
|
|
||
| public string ApplyInternal (string value) | ||
| { | ||
| string result; | ||
|
|
||
| while (true) { | ||
| result = ApplyInternal (value); | ||
|
|
||
| if (result == value) | ||
| return result; | ||
|
|
||
| value = result; | ||
| } | ||
| } | ||
|
|
||
| public string Apply (string value) | ||
| { | ||
| // Handle a "starts with" and "ends with" transform | ||
| if (IsStartsWith && IsEndsWith) { | ||
| if (value.Equals (OldValue, StringComparison.OrdinalIgnoreCase)) | ||
| return NewValue; | ||
|
|
||
| // Don't let this fall through | ||
| return value; | ||
| } | ||
|
|
||
| // Handle a "starts with" transform | ||
| if (IsStartsWith) { | ||
| if (value.StartsWith (OldValue, StringComparison.OrdinalIgnoreCase)) | ||
| return (NewValue + value.Substring (OldValue.Length)).TrimStart ('.'); | ||
jonpryor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return value; | ||
| } | ||
|
|
||
| // Handle an "ends with" transform | ||
| if (IsEndsWith) { | ||
| if (value.EndsWith (OldValue, StringComparison.OrdinalIgnoreCase)) | ||
| return (value.Substring (0, value.Length - OldValue.Length) + NewValue).TrimEnd ('.'); | ||
|
|
||
| return value; | ||
| } | ||
|
|
||
| // Handle an "anywhere" transform | ||
| var value_tokens = value.Split ('.'); | ||
| var match_tokens = OldValue.Split ('.'); | ||
|
|
||
| var results = new List<string> (); | ||
|
|
||
| for (var i = 0; i < value_tokens.Length; i++) { | ||
| if (AtMatch (value_tokens, i, match_tokens, 0)) { | ||
| if (NewValue.HasValue ()) | ||
| results.Add (NewValue); | ||
|
|
||
| i += match_tokens.Length - 1; | ||
| } else { | ||
| results.Add (value_tokens [i]); | ||
| } | ||
| } | ||
|
|
||
| return string.Join (".", results); | ||
| } | ||
|
|
||
| public static bool TryParse (XElement element, [NotNullWhen (true)] out NamespaceTransform? transform) | ||
| { | ||
| var source = element.XGetAttribute ("source"); | ||
| var replacement = element.XGetAttribute ("replacement"); | ||
|
|
||
| if (!source.HasValue () || replacement is null) { | ||
| Report.LogCodedWarning (0, Report.WarningInvalidNamespaceTransform, null, element, element.ToString ()); | ||
| transform = null; | ||
| return false; | ||
| } | ||
|
|
||
| transform = new NamespaceTransform (source, replacement); | ||
| return true; | ||
| } | ||
|
|
||
| private bool AtMatch (string [] valueTokens, int valueIndex, string [] matchTokens, int matchIndex) | ||
| { | ||
| if (matchIndex >= matchTokens.Length) | ||
| return true; | ||
|
|
||
| if (valueIndex >= valueTokens.Length) | ||
| return false; | ||
|
|
||
| if (string.Compare (valueTokens [valueIndex], matchTokens [matchIndex], StringComparison.OrdinalIgnoreCase) == 0) | ||
| return AtMatch (valueTokens, valueIndex + 1, matchTokens, matchIndex + 1); | ||
|
|
||
| return false; | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a
List<T>, or should it be aHashSet<T>?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order is significant, so we need to stick with
List.