From 9434fb989ea481dad664bdfd090e9345b9a7ac13 Mon Sep 17 00:00:00 2001 From: Atsushi Eno Date: Wed, 21 Sep 2016 02:17:21 +0900 Subject: [PATCH] [class-parse] fix class visibility XML output. As part of fixing MSBuild test regression[*1], I noticed that class-parse does not generate correct visibility for class/interface elements, which could affect further API metadata processing. It should not generate "private" for nested types when it should be "" (package private). [*1] it should be ported to OSS... --- .../XmlClassDeclarationBuilder.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Xamarin.Android.Tools.Bytecode/XmlClassDeclarationBuilder.cs b/src/Xamarin.Android.Tools.Bytecode/XmlClassDeclarationBuilder.cs index f69be9e5b..ae1c3ac89 100644 --- a/src/Xamarin.Android.Tools.Bytecode/XmlClassDeclarationBuilder.cs +++ b/src/Xamarin.Android.Tools.Bytecode/XmlClassDeclarationBuilder.cs @@ -93,8 +93,6 @@ static string GetVisibility (ClassAccessFlags accessFlags) return "public"; if ((accessFlags & ClassAccessFlags.Protected) != 0) return "protected"; - if ((accessFlags & ClassAccessFlags.Private) != 0) - return "private"; return ""; }