Reorganize attributes #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes) context: dotnet#58 We have complicated module interdependency between this and xamarin-android, so this set of changes is to fix the situation. So far, here is the changeset summary: - Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android - there will be new Java.Interop.NamingCustomAttributes.shproj which is for use in this repository. It will be shrinked in the later commits to have only required bits in Java/Interop.
As part of dotnet#58 We are not going to need attribute members on this shared project anymore. Those type members should be in Xamarin.Android.NamingCustomAttributes instead.
Contributor
|
The question is, when should we do this? It requires lots of interrelated commits, and this impacts cycle8, so either we wait to do these changes after we branch xamarin-android and Java.Interop for cycle8, or we need to bump everything ~now. |
Contributor
Author
|
I'd rather bring in the changes now IF these variables say "go" for it:
If we apply this change after branching, we will suffer from future cherry-picking difficulty on the other hand. It would happen frequently if we make changes to project structures (e.g. Xamarin.Android.sln). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #58
DO NOT MERGE THIS without merging the related PRs for the mentioned changes.