[build] remove remaining $XA_INTEGRATION variables #370
Conversation
|
@radekdoulik or @jonpryor Jenkins is running these still (I expect the PR build will probably fail): Should I go remove these, too? |
|
I have updated Jenkins configuration to run fxcop instead, so you can remove these. |
radekdoulik
left a comment
radekdoulik
left a comment
There was a problem hiding this comment.
Besides the xa-all and xa-fxcop rules it looks OK to me.
Makefile
Outdated
| $(PACKAGES) $(DEPENDENCIES) $(TESTS) $(XA_INTEGRATION_OUTPUTS) | ||
|
|
||
| xa-all: $(PACKAGES) $(XA_INTEGRATION_OUTPUTS) | ||
| $(PACKAGES) $(DEPENDENCIES) $(TESTS) bin/$(CONFIGURATION)/Java.Interop.dll |
There was a problem hiding this comment.
Why do we need to add bin/$(CONFIGURATION)/Java.Interop.dll to the dependencies list?
Additionally, there's no target to build bin/$(CONFIGURATION)/Java.Interop.dll, so how's this work?
There was a problem hiding this comment.
Whoops, yes, I messed this up.
jonathanpeppers
force-pushed
the
makefile-cleanup
branch
from
1cc1816 to
8f5617f
Compare
Context: dotnet#368 Addressing the comments in dotnet#368, this removes more unused build targets, etc.
jonathanpeppers
force-pushed
the
makefile-cleanup
branch
from
8f5617f to
1cacd6e
Compare
| sed -e 's#@JI_JVM_PATH@#$(JI_JVM_PATH)#g' -e 's#@OS_NAME@#$(DLLMAP_OS_NAME)#g' -e $(JAVA_RUNTIME_ENVIRONMENT_DLLMAP_OVERRIDE_CMD) < $< > $@ | ||
|
|
||
| fxcop: lib/gendarme-2.10/gendarme.exe bin/GendarmeDebug/Java.Interop.dll | ||
| cp src/Java.Interop/obj/Gendarme/Java.Interop.dll.mdb bin/GendarmeDebug/ |
There was a problem hiding this comment.
We still need to copy the mdb file to have lines information in the gendarme output.
There was a problem hiding this comment.
@radekdoulik there isn't an mdb in here at all now. Maybe a change in the latest mono?
bin/GendarmeDebug/ already has the pdb: Java.Interop.pdb. So is this line not needed anymore?
There was a problem hiding this comment.
There is an mdb file, check https://jenkins.mono-project.com/job/Java.Interop-pr-builder/ws/src/Java.Interop/obj/Gendarme/
The Gendarme itself is old, and supports only mdb symbol files, thus we use it here until the Gendarme is updated.
I'm not exactly sure how this was working before: - Gendarme config had no way to import `JdkInfo.props` - Thus usage of `$(JavaCPath)` was using an empty string?
jonathanpeppers
force-pushed
the
makefile-cleanup
branch
from
5ef5bb8 to
e3020c7
Compare
3 participants
Context: #368
Addressing the comments in #368, this removes more unused build targets, etc.