[Java.Interop] use Type.GetType() for Java.Interop.MarshalMemberBuilder
#1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder` Context: dotnet#1184 (comment) Previously we were using `Assembly.Load()` and `Assembly.GetType()`, which require us to ignore various trimmer warnings. If we use `Type.GetType()` with a constant string instead, the trimmer knows how to handle this properly. (The code is also simpler.)
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 21, 2024
Changes: dotnet/java-interop@7d1e705...ae65609 * dotnet/java-interop@ae656097: [Java.Interop] restore `IL2035` suppression (dotnet/java-interop#1195) * dotnet/java-interop@c6e38933: [Java.Interop] use `Type.GetType()` to find `MarshalMemberBuilder` (dotnet/java-interop#1193) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1184 (comment)
Previously we were using
Assembly.Load()andAssembly.GetType(), which require us to ignore various trimmer warnings.If we use
Type.GetType()with a constant string instead, the trimmer knows how to handle this properly. (The code is also simpler.)