[generator] Prevent BG8A08 warning when using ns-replace.
#1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Aug 10, 2023
Changes: dotnet/java-interop@62efc09...5adb4d4 * dotnet/java-interop@5adb4d48: [generator] Prevent BG8A08 warning when using `ns-replace` (dotnet/java-interop#1136) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the NRT work in #1099, we added a warning when the
pathattribute of a "metadata" element isn't provided. However, metadata files can also contain<ns-replace>elements, which do not have apathattribute, and thus erroneously trigger this warning:Skip running any of the standard "metadata" logic when we hit a
<ns-replace>element, as they are handled elsewhere.