[api-xml-adjuster] fix bug #46344 generic nested typename parsing. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something<Like>.This<Was> not expected by the typename parser...
jonpryor
pushed a commit
that referenced
this pull request
Dec 14, 2016
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=46344 `Xamarin.Android.Tools.ApiXmlAdjuster.JavaTypeName.Parse()` would throw an `ArgumentOutOfRangeException` when encountering generic nested types on generic types. Given the following valid Java code: // Java class GenericOuter<TOuter> { public class GenericInner<TInner> { } } class Gapp { public static void main (String[] args) { GenericOuter<Integer>.GenericInner<String> v = null; } } Then the following would fail: JavaTypeName.Parse("GenericOuter<Integer>.GenericInner<String>") System.ArgumentOutOfRangeException: Length cannot be less than zero. Parameter name: length ... Fix `JavaTypeName.Parse()` to support parsing nested generic types on generic types.
jonpryor
pushed a commit
that referenced
this pull request
Mar 8, 2021
Changes: dotnet/android-tools@479931c...554d45a * dotnet/android-tools@554d45a: [Xamarin.Android.Tools.AndroidSdk] Fix CS8600 in AndroidSdkBase (#107) * dotnet/android-tools@19454f9: Bump to xamarin/LibZipSharp/main@86f8ae57 [1.0.24] (#111) * dotnet/android-tools@3582b39: [macOS] fix DirectoryNotFoundException on clean systems (#110) * dotnet/android-tools@ca820e5: Bump to xamarin/LibZipSharp/main@521b54ec [1.0.23] (#109)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something.This not expected by the typename parser...