[generator] Remove [Obsolete] style compatibility hacks. #1025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditionally
generatorwas inconsistent with the style in which it generated[Obsolete]attributes, such as:We wrote a temporary compatibility layer to preserve these differences when we refactored
generator. This allowed us to do a source code level text compare against a large corpus of generated code (Mono.Android/AndroidX/GPS) to ensure there were no changes.Now that we are passed this phase, we can remove these hacks and standardize on
[global::System.Obsolete]and[global::System.Obsolete (@"message")].XA test build to ensure there were no actual changes via ApiCompat testing: dotnet/android#7253.