Commit e50a1cb
committed
[Xamarin.Android.Tools.Bytecode-Tests] Update output for JDK8.
JDK 8 generates different output from JDK 7, which unfortunately
breaks the unit tests (and thus prevents us from having a "green"
build on our Jenkins server, which is bad).
For JavaEnum.class, JDK 7's javac emitted an extra, *duplicate*,
constant pool entry:
NameAndType(nameIndex=27 descriptorIndex=28 Name="<init>" Descriptor="(Ljava/lang/String;I)V")
I assume it was a JDK 7 bug fixed in JDK 8.
For JavaType.class, JDK 8 is generating many more constant pool
entries -- 183 vs. 177 -- which I haven't further explored.
As important is that the JDK 8 compiler has changed the behavior for
parameter names of synthetic methods. JDK 7 would emit *actual* names
for these parameters when `javac -g` was used, using e.g. `x0` as the
parameter name.
JDK 8 doesn't emit parameter names for synthetic method parameters
*at all*.
In the interest of keeping the unit test framework simpler, bump the
expected outputs to mirror that of JDK 8 `javac` output, because
nobody should be using JDK 7 anymore...
This should allow all Xamarin.Android.Tools.Bytecode tests to pass
on Jenkins.1 parent 9778381 commit e50a1cb
File tree
3 files changed
+7
-7
lines changed- src/Xamarin.Android.Tools.Bytecode/Tests
3 files changed
+7
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
| 312 | + | |
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
318 | 318 | | |
319 | 319 | | |
320 | | - | |
| 320 | + | |
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
| |||
0 commit comments