Skip to content

Commit 63dc5db

Browse files
committed
[class-parse] fix class visibility XML output.
As part of fixing MSBuild test regression[*1], I noticed that class-parse does not generate correct visibility for class/interface elements, which could affect further API metadata processing. It should not generate "private" for nested types when it should be "" (package private). [*1] it should be ported to OSS...
1 parent 0e8a17c commit 63dc5db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Xamarin.Android.Tools.Bytecode/XmlClassDeclarationBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public XElement ToXElement ()
3939
new XAttribute ("name", GetThisClassName ()),
4040
new XAttribute ("jni-signature", "L" + classFile.ThisClass.Name.Value + ";"),
4141
new XAttribute ("static", classFile.IsStatic),
42-
new XAttribute ("visibility", GetVisibility (classFile.Visibility)),
42+
new XAttribute ("visibility", GetClassVisibility (classFile.Visibility)),
4343
GetTypeParmeters (signature == null ? null : signature.TypeParameters),
4444
GetImplementedInterfaces (),
4545
GetConstructors (),

0 commit comments

Comments
 (0)