Skip to content

Commit 5318261

Browse files
authored
[build] Update Microsoft.* NuGet package versions (#1055)
Context: c936d09 Context: https://devdiv.visualstudio.com/DevDiv/_componentGovernance/112825/alert/7082457?typeId=12393424 Context: microsoft/vstest#4098 [Component Governance][0] is a Microsoft internal tool which checks for known security issues in product dependencies. It is currently reporting a defect in Java.Interop because of Newtonsoft.Json 9.0.1 and [GHSA-5crp-9r3c-p9vr][1]. This is a tad odd because Java.Interop *does not use* Newtonsoft.Json. Apparently the [Microsoft.NET.Test.Sdk 16.11.0 package][2] pulls in Newtonsoft.Json 9.0.1 when `$(TargetFramework)`=UAP10.0, which is also something that Java.Interop does not use. Regardless! Take this as a reminder and opportunity to update some NuGet packages. Update all of the `Microsoft.*` NuGet packages *except* `Microsoft.Xml.SgmlReader`; as mentioned in c936d09, newer versions of that package have an API break, which prevent us from trivially bumping the dependency. Most other `Microsoft.*` NuGet packages are updated to the latest *non-preview* versions listed on NuGet.org and available on [dotnet-public][3]. `Microsoft.NET.Test.Sdk` is updated to the *preview* version 17.5.0-preview-20221003-04, because the [current stable 17.3.2][4] version still references Newtonsoft.Json 9.0.1 for UAP10.0. I have also sorted the `Microsoft.*` entries in `Directory.Build.targets`. One oddity: updating the `Microsoft.NET.Test.Sdk` NuGet package to 17.4.0-preview-20220726-02 or later results in a CS0017! samples/Hello-Java.Base/Program.cs(15,22): error CS0017: Program has more than one entry point defined. Compile with /main to specify the type that contains the entry point. This is because `Hello-Java.Base.csproj` references `TestJVM.csproj`, which references `Microsoft.NET.Test.Sdk`, and more recent versions of the `Microsoft.NET.Test.Sdk` package contain `buildTransitive/netcoreapp3.1/Microsoft.NET.Test.Sdk.Program.cs`, which contains a `Main()` method! [Microsoft.VisualStudio.TestPlatform.TestSDKAutoGeneratedCode] class AutoGeneratedProgram {static void Main(string[] args){}} See also microsoft/vstest#4098. Prevent the CS0017 by setting the [`$(StartupObject)`][5] MSBuild property to `Hello.App`. [0]: https://docs.opensource.microsoft.com/tools/cg/ [1]: GHSA-5crp-9r3c-p9vr [2]: https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/16.11.0 [3]: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json [4]: https://www.fuget.org/packages/Microsoft.NET.Test.Sdk/17.3.2 [5]: https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022
1 parent 8e18c90 commit 5318261

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

Directory.Build.targets

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@
1111

1212
<!-- NuGet Dependencies -->
1313
<ItemGroup>
14-
<PackageReference Update="Microsoft.Xml.SgmlReader" Version="1.8.16" />
1514
<PackageReference Update="GitInfo" Version="2.1.2" />
1615
<PackageReference Update="HtmlAgilityPack" Version="1.11.30" />
1716
<PackageReference Update="Irony" Version="1.1.0" />
18-
<PackageReference Update="Microsoft.Build.Framework" Version="16.11.0" />
19-
<PackageReference Update="Microsoft.Build.Utilities.Core" Version="16.11.0" />
20-
<PackageReference Update="Microsoft.CodeAnalysis.CSharp" Version="3.11.0" />
17+
<PackageReference Update="Microsoft.Build.Framework" Version="17.3.2" />
18+
<PackageReference Update="Microsoft.Build.Utilities.Core" Version="17.3.2" />
19+
<PackageReference Update="Microsoft.CodeAnalysis.CSharp" Version="4.3.1" />
2120
<PackageReference Update="Microsoft.DotNet.GenAPI" Version="7.0.0-beta.22103.1" />
22-
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="16.11.0" />
23-
<PackageReference Update="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" />
21+
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.5.0-preview-20221003-04" />
22+
<PackageReference Update="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
2423
<PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.1.1" />
24+
<PackageReference Update="Microsoft.Xml.SgmlReader" Version="1.8.16" />
2525
<PackageReference Update="Mono.CSharp" Version="4.0.0.143" />
2626
<PackageReference Update="Mono.Linq.Expressions" Version="2.0.0" />
2727
<PackageReference Update="Mono.Options" Version="6.12.0.148" />

samples/Hello-Java.Base/Hello-Java.Base.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<OutputType>Exe</OutputType>
66
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
77
<Nullable>enable</Nullable>
8+
<StartupObject>Hello.App</StartupObject>
89
</PropertyGroup>
910

1011
<ItemGroup>

tests/Java.Interop.Tools.JavaTypeSystem-Tests/Java.Interop.Tools.JavaTypeSystem-Tests.csproj

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
</PropertyGroup>
1414

1515
<ItemGroup>
16-
<PackageReference Include="nunit" Version="3.12.0" />
17-
<PackageReference Include="NUnit.ConsoleRunner" Version="3.11.1" />
18-
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1">
16+
<PackageReference Include="nunit" />
17+
<PackageReference Include="NUnit.ConsoleRunner" />
18+
<PackageReference Include="NUnit3TestAdapter">
1919
<PrivateAssets>all</PrivateAssets>
2020
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2121
</PackageReference>
22-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.2.0" />
23-
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" />
22+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
23+
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" />
2424
</ItemGroup>
2525

2626
<ItemGroup>

0 commit comments

Comments
 (0)