[generator] Create base class for unit tests.

Author: jpobst

tools/generator/Tests/Unit-Tests/CodeGeneratorTestBase.cs

@@ -0,0 +1,59 @@
+using System;
+using System.IO;
+using System.Reflection;
+using System.Text;
+using MonoDroid.Generation;
+using NUnit.Framework;
+
+namespace generatortests.Unit_Tests
+{
+	abstract class CodeGeneratorTestBase
+	{
+		protected CodeGenerator generator;
+		protected StringBuilder builder;
+		protected StringWriter writer;
+		protected CodeGenerationOptions options;
+
+		[SetUp]
+		public void SetUp ()
+		{
+			builder = new StringBuilder ();
+			writer = new StringWriter (builder);
+			options = CreateOptions ();
+
+			generator = options.CreateCodeGenerator (writer);
+		}
+
+		[TearDown]
+		public void TearDown ()
+		{
+			writer.Dispose ();
+		}
+
+		protected virtual CodeGenerationOptions CreateOptions ()
+		{
+			return new CodeGenerationOptions {
+				CodeGenerationTarget = Target,
+			};
+		}
+
+		protected abstract Xamarin.Android.Binder.CodeGenerationTarget Target { get; }
+
+		// Get the test results from "Common" for tests with the same results regardless of Target
+		protected string GetExpected (string testName)
+		{
+			var root = Path.GetDirectoryName (Assembly.GetExecutingAssembly ().Location);
+
+			return File.ReadAllText (Path.Combine (root, "Unit-Tests", "CodeGeneratorExpectedResults", "Common", $"{testName}.txt")).NormalizeLineEndings ();
+		}
+
+		// Get the test results from "JavaInterop1" or "XamarinAndroid" for tests with the different results per Target
+		protected string GetTargetedExpected (string testName)
+		{
+			var target = Target.ToString ();
+			var root = Path.GetDirectoryName (Assembly.GetExecutingAssembly ().Location);
+
+			return File.ReadAllText (Path.Combine (root, "Unit-Tests", "CodeGeneratorExpectedResults", target, $"{testName}.txt")).NormalizeLineEndings ();
+		}
+	}
+}

tools/generator/Tests/Unit-Tests/CodeGeneratorTests.cs

@@ -1,40 +1,27 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
 using generatortests.Unit_Tests;
 using MonoDroid.Generation;
 using NUnit.Framework;
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Reflection;
-using System.Text;
+using Xamarin.Android.Binder;
 
 namespace generatortests
 {
-	abstract class CodeGeneratorTests
+	[TestFixture]
+	class JavaInteropCodeGeneratorTests : CodeGeneratorTests
 	{
-		protected CodeGenerator generator;
-		protected StringBuilder builder;
-		protected StringWriter writer;
-		protected CodeGenerationOptions options;
-
-		[SetUp]
-		public void SetUp ()
-		{
-			builder = new StringBuilder ();
-			writer = new StringWriter (builder);
-			options = new CodeGenerationOptions {
-				CodeGenerationTarget = Target
-			};
-			generator = options.CreateCodeGenerator (writer);
-		}
-
-		[TearDown]
-		public void TearDown ()
-		{
-			writer.Dispose ();
-		}
+		protected override CodeGenerationTarget Target => CodeGenerationTarget.JavaInterop1;
+	}
 
-		protected abstract Xamarin.Android.Binder.CodeGenerationTarget Target { get; }
+	[TestFixture]
+	class XamarinAndroidCodeGeneratorTests : CodeGeneratorTests
+	{
+		protected override CodeGenerationTarget Target => CodeGenerationTarget.XamarinAndroid;
+	}
 
+	abstract class CodeGeneratorTests : CodeGeneratorTestBase
+	{
 		[Test]
 		public void WriteCharSequenceEnumerator ()
 		{
@@ -840,22 +827,5 @@ public void WritePropertyInvoker ()
 
 			Assert.AreEqual (GetExpected (nameof (WritePropertyInvoker)), writer.ToString ().NormalizeLineEndings ());
 		}
-
-		// Get the test results from "Common" for tests with the same results regardless of Target
-		string GetExpected (string testName)
-		{
-			var root = Path.GetDirectoryName (Assembly.GetExecutingAssembly ().Location);
-
-			return File.ReadAllText (Path.Combine (root, "Unit-Tests", "CodeGeneratorExpectedResults", "Common", $"{testName}.txt")).NormalizeLineEndings ();
-		}
-
-		// Get the test results from "JavaInterop1" or "XamarinAndroid" for tests with the different results per Target
-		string GetTargetedExpected (string testName)
-		{
-			var target = Target.ToString ();
-			var root = Path.GetDirectoryName (Assembly.GetExecutingAssembly ().Location);
-
-			return File.ReadAllText (Path.Combine (root, "Unit-Tests", "CodeGeneratorExpectedResults", target, $"{testName}.txt")).NormalizeLineEndings ();
-		}
 	}
 }

tools/generator/Tests/Unit-Tests/JavaInteropCodeGeneratorTests.cs

@@ -69,13 +69,12 @@
     <Compile Include="Integration-Tests\GenericArguments.cs" />
     <Compile Include="Integration-Tests\InterfaceMethodsConflict.cs" />
     <Compile Include="SupportFiles\RegisterAttribute.cs" />
+    <Compile Include="Unit-Tests\CodeGeneratorTestBase.cs" />
     <Compile Include="Unit-Tests\CodeGeneratorTests.cs" />
     <Compile Include="Unit-Tests\AdjusterTests.cs" />
-    <Compile Include="Unit-Tests\JavaInteropCodeGeneratorTests.cs" />
     <Compile Include="Unit-Tests\ManagedTests.cs" />
     <Compile Include="Unit-Tests\SupportTypes.cs" />
     <Compile Include="Unit-Tests\TestExtensions.cs" />
-    <Compile Include="Unit-Tests\XamarinAndroidCodeGeneratorTests.cs" />
     <Compile Include="Unit-Tests\XmlTests.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />