Skip to content

Commit 20c12f1

Browse files
committed
More changes.
1 parent 4545ff3 commit 20c12f1

File tree

7 files changed

+10
-33
lines changed

7 files changed

+10
-33
lines changed

Directory.Build.props

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,14 @@
33
<!-- Note: MUST be imported *after* $(Configuration) is set! -->
44
<PropertyGroup>
55
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
6-
<!-- Mono's MSBuild does not support some implicit .NET6 source generator stuff
7-
<TreatWarningsAsErrors Condition=" '$(Configuration)' == 'Release' And '$(MSBuildRuntimeType)' != 'Mono' ">true</TreatWarningsAsErrors> -->
86
<_OutputPath>$(MSBuildThisFileDirectory)bin\Build$(Configuration)\</_OutputPath>
97
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
108
<ProduceReferenceAssemblyInOutDir>true</ProduceReferenceAssemblyInOutDir>
119
<DotNetTargetFrameworkVersion>7.0</DotNetTargetFrameworkVersion>
1210
<DotNetTargetFramework>net$(DotNetTargetFrameworkVersion)</DotNetTargetFramework>
13-
<!--
14-
Workaround for https://github.com/NuGet/Home/issues/6461 (VSWin Only)
15-
Even though we don't build NuGet packages, it still attempts to build the NuGet package name, which includes
16-
the assembly version if PackageVersion isn't specified. Because our assemblies have different versions
17-
per-TFM, that causes a problem because the package can't have multiple versions in it.
18-
Set a dummy PackageVersion because we don't actually need it.
19-
-->
20-
<PackageVersion>1.0.0.0</PackageVersion>
11+
<!-- These assemblies are used by Xamarin.Android.Build.Tasks which must be netstandard2.0
12+
in order to be loaded into Visual Studio -->
13+
<MSBuildRequiredTargetFramework>netstandard2.0</MSBuildRequiredTargetFramework>
2114
</PropertyGroup>
2215

2316
<Import
@@ -54,7 +47,7 @@
5447
<!-- Workaround: https://github.com/dotnet/runtime/issues/55992 -->
5548
<UseAppHost>False</UseAppHost>
5649
<AppendTargetFrameworkToOutputPath Condition=" '$(AppendTargetFrameworkToOutputPath)' == '' ">False</AppendTargetFrameworkToOutputPath>
57-
<!--<BaseIntermediateOutputPath Condition=" '$(BaseIntermediateOutputPath)' == '' ">obj\</BaseIntermediateOutputPath>-->
50+
<BaseIntermediateOutputPath Condition=" '$(BaseIntermediateOutputPath)' == '' ">obj\</BaseIntermediateOutputPath>
5851
</PropertyGroup>
5952

6053
<PropertyGroup>

TargetFrameworkDependentValues.props

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,30 +19,18 @@
1919
<JICoreLibVersion>$(JINetCoreLibVersion)</JICoreLibVersion>
2020
</PropertyGroup>
2121

22-
<!--<PropertyGroup Condition=" '$(JIBuildingForNetCoreApp)' != 'True' ">
23-
<IntermediateOutputPath>$(BaseIntermediateOutputPath)\$(Configuration)</IntermediateOutputPath>
24-
<BuildToolOutputFullPath>$(MSBuildThisFileDirectory)bin\Build$(Configuration)\</BuildToolOutputFullPath>
25-
<ToolOutputFullPath>$(MSBuildThisFileDirectory)bin\$(Configuration)\</ToolOutputFullPath>
26-
<TestOutputFullPath>$(MSBuildThisFileDirectory)bin\Test$(Configuration)\</TestOutputFullPath>
27-
<UtilityOutputFullPath Condition=" '$(UtilityOutputFullPath)' == '' ">$(ToolOutputFullPath)</UtilityOutputFullPath>
28-
<_XamarinAndroidCecilPath Condition=" '$(CecilSourceDirectory)' != '' And Exists('$(UtilityOutputFullPath)Xamarin.Android.Cecil.dll') ">$(UtilityOutputFullPath)Xamarin.Android.Cecil.dll</_XamarinAndroidCecilPath>
29-
<JIUtilityVersion>$(JIOldToolVersion)</JIUtilityVersion>
30-
<JICoreLibVersion>$(JIOldCoreLibVersion)</JICoreLibVersion>
31-
</PropertyGroup>-->
32-
3322
<PropertyGroup>
3423
<Runtime Condition="'$(OS)' != 'Windows_NT'">mono</Runtime>
3524
<_JNIEnvGenPath>$(BuildToolOutputFullPath)jnienv-gen.dll</_JNIEnvGenPath>
3625
<_RunJNIEnvGen>$(DotnetToolPath) "$(_JNIEnvGenPath)"</_RunJNIEnvGen>
3726
</PropertyGroup>
3827

39-
<!-- The net6.0 versions of these are stricter and require overloads not available in .NET Framework, so start with just .NET Framework -->
40-
<PropertyGroup Condition=" '$(JIBuildingForNetCoreApp)' != 'True' ">
28+
<PropertyGroup>
4129
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
4230
<WarningsAsErrors>$(WarningsAsErrors);CA1307;CA1309;CA1310</WarningsAsErrors>
4331
</PropertyGroup>
4432

45-
<PropertyGroup Condition=" '$(JIBuildingForNetCoreApp)' == 'True' ">
33+
<PropertyGroup>
4634
<NoWarn>$(NoWarn);CA1307;CA1309;CA1310</NoWarn>
4735
</PropertyGroup>
4836

build-tools/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77

88
<Import Project="..\..\TargetFrameworkDependentValues.props" />
99

10-
<PropertyGroup>
11-
<OutputPath>$(BuildToolOutputFullPathNoTF)</OutputPath>
12-
</PropertyGroup>
13-
1410
<PropertyGroup>
1511
<OutputPath>$(BuildToolOutputFullPathNoTF)</OutputPath>
1612
<GitDefaultBranch>main</GitDefaultBranch>

src/Java.Interop.Localization/Java.Interop.Localization.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netstandard2.0</TargetFramework>
4+
<TargetFramework>$(MSBuildRequiredTargetFramework)</TargetFramework>
55
<LangVersion>8.0</LangVersion>
66
<Nullable>enable</Nullable>
77
<DefineConstants>INTERNAL_NULLABLE_ATTRIBUTES</DefineConstants>

src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netstandard2.0</TargetFramework>
4+
<TargetFramework>$(MSBuildRequiredTargetFramework)</TargetFramework>
55
<LangVersion>8.0</LangVersion>
66
<Nullable>enable</Nullable>
77
<DefineConstants>INTERNAL_NULLABLE_ATTRIBUTES</DefineConstants>

src/Java.Interop.Tools.Diagnostics/Java.Interop.Tools.Diagnostics.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netstandard2.0</TargetFramework>
4+
<TargetFramework>$(MSBuildRequiredTargetFramework)</TargetFramework>
55
<LangVersion>8.0</LangVersion>
66
<Nullable>enable</Nullable>
77
<DefineConstants>INTERNAL_NULLABLE_ATTRIBUTES</DefineConstants>

src/Java.Interop.Tools.JavaCallableWrappers/Java.Interop.Tools.JavaCallableWrappers.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netstandard2.0</TargetFramework>
4+
<TargetFramework>$(MSBuildRequiredTargetFramework)</TargetFramework>
55
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
66
<LangVersion>8.0</LangVersion>
77
<Nullable>enable</Nullable>

0 commit comments

Comments
 (0)