Net Standard 2.0 only FSharp.Core #9801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
changed the title
Contributor
Author
|
Bugger I guess I need to deal with the fcs build. |
KevinRansom
force-pushed
the
removedesktopfsharpcore
branch
from
93af875 to
e7cf6fb
Compare
brettfo
approved these changes
Jul 29, 2020
cartermp
reviewed
Jul 29, 2020
tests/FSharp.Compiler.ComponentTests/ErrorMessages/ConfusingTypeName.fs
Outdated
Show resolved
Hide resolved
...finitionLocationAttributeFileDoesnotExist/DefinitionLocationAttributeFileDoesnotExist.csproj
Outdated
Show resolved
Hide resolved
KevinRansom
force-pushed
the
removedesktopfsharpcore
branch
from
10d2d04 to
d25cac8
Compare
cartermp
approved these changes
Jul 30, 2020
vzarytovskii
pushed a commit
to vzarytovskii/fsharp
that referenced
this pull request
Aug 4, 2020
* Net standard only FSharp.Core * temp
KevinRansom
added a commit
that referenced
this pull request
Aug 6, 2020
…9870) * Net Standard 2.0 only FSharp.Core (#9801) * Net standard only FSharp.Core * temp * Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests * Fixed netcoreapp30 -> netcoreapp31 test references * Cleaned up projects, added testplatform package, moved some tests to new suite * Tests changes * Revert accidental revert * Added missing tests * Cleaned up packages, fixed tests * Add System.Runtime to references Co-authored-by: Kevin Ransom (msft) <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…otnet#9870) * Net Standard 2.0 only FSharp.Core (dotnet#9801) * Net standard only FSharp.Core * temp * Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests * Fixed netcoreapp30 -> netcoreapp31 test references * Cleaned up projects, added testplatform package, moved some tests to new suite * Tests changes * Revert accidental revert * Added missing tests * Cleaned up packages, fixed tests * Add System.Runtime to references Co-authored-by: Kevin Ransom (msft) <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Net standard only FSharp.Core * temp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FSharp.Core nuget package will only ship netstandard2.0 binaries.
The binaries are fully compatible with net472, and netcoreapp2.0 and up.
For developers targeting earlier releases of the DotNET framework should use 4.7.2
It require some bug fixing to the test framework and simulated msbuildresolver.