Use roslyn API to display extended completion and fix quirks with scripts/top of file #9165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
changed the title
cartermp
changed the title
KevinRansom
approved these changes
May 11, 2020
TIHan
reviewed
May 12, 2020
TIHan
approved these changes
May 12, 2020
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
Looks good, one comment on the newline though.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…ipts/top of file (dotnet#9165) * Use roslyn API to show unopened namespace in extended completion * Properly add open decls when at the top of a file
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…ipts/top of file (dotnet#9165) * Use roslyn API to show unopened namespace in extended completion * Properly add open decls when at the top of a file
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…ipts/top of file (dotnet#9165) * Use roslyn API to show unopened namespace in extended completion * Properly add open decls when at the top of a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this with the change
What's neat about this is that the completion window will resize dynamically as the items to the right get larger. This also happens as you scroll, so if you have some items with a giant namespace but they aren't visible in the window, the window won't get large until they are visible. This is all just the Roslyn tooling infrastructure under the hood powering this. We only need to pass in a string 🙂
Also fixes #9167, #9166