-
Notifications
You must be signed in to change notification settings - Fork 830
build net472 specific dependency manager to make ngen happy #8939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KevinRansom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brett in dev16.6 this needs changing: https://github.com/dotnet/fsharp/blob/release/dev16.6/setup/Swix/Microsoft.FSharp.Compiler.MSBuild/Microsoft.FSharp.Compiler.MSBuild.csproj#L97
Might as well do it here in master as well to save the grief of forgetting it in 16.6.
|
@KevinRansom Updated PR to include that line, it was missing from |
|
@brettfo , yes I know, I had to go looking for it, because, I was sure it must be there :-) |
|
Also, confirmed that with this change |
|
After much pain, the NGEN logs are clean and internal RPS test doesn't list FSharp.Compiler.Private or Interactive.DependencyManager. Once green I'll merge this so it can eventually flow into VS branches. |
Internal RPS looks clean. Subsequent VS insertion will require binding redirects for
Interactive.DependencyManager.dlladded to vsn.exe.config.