Skip to content

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented Apr 13, 2020

Internal RPS looks clean. Subsequent VS insertion will require binding redirects for Interactive.DependencyManager.dll added to vsn.exe.config.

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brett in dev16.6 this needs changing: https://github.com/dotnet/fsharp/blob/release/dev16.6/setup/Swix/Microsoft.FSharp.Compiler.MSBuild/Microsoft.FSharp.Compiler.MSBuild.csproj#L97

Might as well do it here in master as well to save the grief of forgetting it in 16.6.

@brettfo
Copy link
Member Author

brettfo commented Apr 13, 2020

@KevinRansom Updated PR to include that line, it was missing from master.

@KevinRansom
Copy link
Contributor

@brettfo , yes I know, I had to go looking for it, because, I was sure it must be there :-)

@brettfo
Copy link
Member Author

brettfo commented Apr 13, 2020

Also, confirmed that with this change VisualFSharpFull.vsix contains the net472 variant, and loading up that in ILSpy shows the offending types/methods as not present, but they are in the netstandard2.0 one.

@brettfo brettfo changed the title build net472 specific dependency manager to make ngen happy [WIP] build net472 specific dependency manager to make ngen happy Apr 13, 2020
@brettfo brettfo changed the title [WIP] build net472 specific dependency manager to make ngen happy build net472 specific dependency manager to make ngen happy Apr 14, 2020
@brettfo brettfo changed the title build net472 specific dependency manager to make ngen happy [WIP] build net472 specific dependency manager to make ngen happy Apr 14, 2020
@brettfo
Copy link
Member Author

brettfo commented Apr 15, 2020

After much pain, the NGEN logs are clean and internal RPS test doesn't list FSharp.Compiler.Private or Interactive.DependencyManager. Once green I'll merge this so it can eventually flow into VS branches.

@brettfo brettfo changed the title [WIP] build net472 specific dependency manager to make ngen happy build net472 specific dependency manager to make ngen happy Apr 15, 2020
@brettfo brettfo merged commit 8d7382f into dotnet:master Apr 16, 2020
brettfo added a commit to brettfo/fsharp that referenced this pull request Apr 22, 2020
@brettfo brettfo deleted the dependency-tfm branch November 2, 2020 19:21
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants