Fix completion inside last part of long ident #3711
Conversation
…dent which is used father in GetDeclaredItems to determine the RHL type
|
Maybe we should move QuickParse.fs to FCS? It is VS-agnostic and can be used in all tools. |
|
@auduchinok done. Also I think parsing long idents should be hidden behind FCS API entirely. Stuff like |
|
@vasily-kirichenko thank you! |
|
TBH, I didn't think much about that type, so it's not that elegant. The whole API needs a serious rethinking and simplifying based on real usage scenarios in Ionide, Rider and VS. |
|
It's ready |
| let UnusedOpensAnalyzerInitialDelay = 0 (* 2000 *) (* milliseconds *) | ||
| let SimplifyNameInitialDelay = 2000 (* milliseconds *) | ||
| let SimplifyNameEachItemDelay = 5 (* milliseconds *) | ||
| let SimplifyNameEachItemDelay = 0 (* milliseconds *) |
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Requesting a few minor changes
src/fsharp/vs/QuickParse.fsi
Outdated
| module internal QuickParse = | ||
| #endif | ||
| val MagicalAdjustmentConstant : int | ||
| val CorrectIdentifierToken : s: string -> tokenTag: int -> int |
There was a problem hiding this comment.
Minor things
- Could you give better argument names please, e.g.
tokenTextnots? - Also in the implementation.
- Also a
///comment on each public thing please - Add a blank line between before each
///comment section
src/fsharp/vs/service.fsi
Outdated
| /// </param> | ||
| /// <param name="userOpName">An optional string used for tracing compiler operations associated with this request.</param> | ||
| member GetDeclarationListInfo : ParsedFileResultsOpt:FSharpParseFileResults option * line: int * colAtEndOfPartialName: int * lineText:string * qualifyingNames: string list * partialName: string * getAllSymbols: (unit -> AssemblySymbol list) * ?hasTextChangedSinceLastTypecheck: (obj * range -> bool) * ?userOpName: string -> Async<FSharpDeclarationListInfo> | ||
| member GetDeclarationListInfo : ParsedFileResultsOpt:FSharpParseFileResults option * line: int * colAtEndOfPartialName: int * lineText:string * partialName: PartialLongName * getAllSymbols: (unit -> AssemblySymbol list) * ?hasTextChangedSinceLastTypecheck: (obj * range -> bool) * ?userOpName: string -> Async<FSharpDeclarationListInfo> |
There was a problem hiding this comment.
-
Please fix up the
paramdocumentation so the parameter list match. Also forGetDeclarationListSymbols -
Please add a sentence in the
///comment text forpartialNamethe saying that theQuickParsemodule can be used to get apartialNamevalue
|
All done, waiting until it's green. |
|
ready |
* make SimplifyNameEachItemDelay zero * QuickParse.GetPartialLongNameEx returns pos of the last dot in long ident which is used father in GetDeclaredItems to determine the RHL type * refactoring * fix QuickParse * move QuickParse to FSharp.Compiler.Private project * add QuickParse to all projects which need it * fix QuickParse * add a test * fix QuickParse * xml docs * embed colAtEndOfNamesAndResidue into PartialLongName * revert unrelated change
6 participants
This fixes #3709
Was:
Now: