Align signature/implementation argument names in FSharp.Core #3531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
Contributor
Author
|
@dotnet-bot test Windows_NT Release_ci_part2 Build please |
Contributor
Author
|
This is ready, but there was a timeout in CI |
Contributor
Author
|
@dotnet-bot test Windows_NT Release_ci_part2 Build please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #3527 to actually fix up argument names in FSHarp.Core.
I did this by repeatedly using the quickfix in Visual Studio implemented in #3527. This was also a way of manually testing the quick fix. There were no problems with the quickfix itself, it made this very smooth and accurate