Fix race in graph checking of type extensions #19062
Merged
+111
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❗ Release notes required
|
majocha
changed the title
Contributor
Author
|
To unblock #19028 |
Contributor
|
It has been too long since I understood all this, so could you high-level explain to me why this works? Does signature conformance happen after the parallel phase? |
Contributor
Author
No, it seems it just does SetIdent in the opposite direction sig -> impl. Or extended type -> extensions. :) So what is being mutated is naturally isolated by graph checking. This seems the only place this happens so we can save the declared ident here. |
Contributor
|
Thanks, this is a clever solution. Well done! |
T-Gro
reviewed
Nov 10, 2025
T-Gro
reviewed
Nov 10, 2025
T-Gro
reviewed
Nov 10, 2025
T-Gro
reviewed
Nov 10, 2025
T-Gro
reviewed
Nov 10, 2025
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
T-Gro
approved these changes
Nov 11, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19033
By saving the declared type argument name instead of mutating (possibly concurrently) the source typar.
Checklist