Skip to content

Fix exn signature range #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

Fix exn signature range #18982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5a0050
Fix exn signature range
ncave Oct 10, 2025
91e36a4
Add exn signature tests
ncave Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Symbols/SymbolHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ module internal SymbolHelpers =
| Item.Value vref | Item.CustomBuilder (_, vref) -> Some (rangeOfValRef preferFlag vref)
| Item.UnionCase(ucinfo, _) -> Some (rangeOfUnionCaseInfo preferFlag ucinfo)
| Item.ActivePatternCase apref -> Some (rangeOfValRef preferFlag apref.ActivePatternVal)
| Item.ExnCase tcref -> Some tcref.Range
| Item.ExnCase tcref -> Some (rangeOfEntityRef preferFlag tcref)
| Item.AnonRecdField (_,_,_,m) -> Some m
| Item.RecdField rfinfo -> Some (rangeOfRecdFieldInfo preferFlag rfinfo)
| Item.UnionCaseField (UnionCaseInfo (_, ucref), fieldIndex) -> Some (rangeOfRecdField preferFlag (ucref.FieldByIndex(fieldIndex)))
Expand Down
41 changes: 37 additions & 4 deletions tests/FSharp.Compiler.ComponentTests/FSharpChecker/FindReferences.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,22 @@ val myFunc2: param: int -> int
}

module Exceptions =
let project() = SyntheticProject.Create(
{ sourceFile "First" [] with ExtraSource = "exception MyException of string" },
{ sourceFile "Second" [] with ExtraSource = """
let source1 = "exception MyException of string"
let signature1 = "exception MyException of string"

let source2 = """
open ModuleFirst
let foo x = raise (MyException "foo")""" })
let foo x = raise (MyException "foo")
"""
let project() = SyntheticProject.Create(
{ sourceFile "First" [] with ExtraSource = source1 },
{ sourceFile "Second" [] with ExtraSource = source2 })

let projectWithSignature() = SyntheticProject.Create(
{ sourceFile "First" [] with
ExtraSource = source1
SignatureFile = Custom signature1 },
{ sourceFile "Second" [] with ExtraSource = source2 })

[<Fact>]
let ``We find exception from definition`` () =
Expand All @@ -292,6 +303,28 @@ let foo x = raise (MyException "foo")""" })
])
}

[<Fact>]
let ``We find exception from definition and signature`` () =
projectWithSignature().Workflow {
placeCursor "First" 6 21 "exception MyException of string" ["MyException"]
findAllReferences (expectToFind [
"FileFirst.fs", 6, 10, 21
"FileFirst.fsi", 2, 10, 21
"FileSecond.fs", 8, 19, 30
])
}

[<Fact>]
let ``We find exception from usage and signature`` () =
projectWithSignature().Workflow {
placeCursor "Second" 8 30 "raise (MyException \"foo\")" ["MyException"]
findAllReferences (expectToFind [
"FileFirst.fs", 6, 10, 21
"FileFirst.fsi", 2, 10, 21
"FileSecond.fs", 8, 19, 30
])
}

module Attributes =

let project() = SyntheticProject.Create(
Expand Down
Loading