From a0f4bf8f0c4c5eae323c7fe1f350dde6a582be0a Mon Sep 17 00:00:00 2001 From: Tom Deseyn Date: Wed, 12 Jun 2024 13:52:09 +0200 Subject: [PATCH] source-build: don't use PublishReadyToRun on Mono-builds. Crossgen2 is not built with Mono-based .NET SDKs. --- Directory.Build.props | 7 +++++++ buildtools/AssemblyCheck/AssemblyCheck.fsproj | 2 +- buildtools/fslex/fslex.fsproj | 2 +- buildtools/fsyacc/fsyacc.fsproj | 2 +- eng/SourceBuild.props | 2 +- eng/build.sh | 2 +- src/fsc/fscProject/fsc.fsproj | 2 +- src/fsi/fsiProject/fsi.fsproj | 2 +- 8 files changed, 14 insertions(+), 7 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 47b495dffb..463feb6cbb 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -34,6 +34,13 @@ $(OtherFlags) --realsig+ + + + true + + false + + diff --git a/buildtools/AssemblyCheck/AssemblyCheck.fsproj b/buildtools/AssemblyCheck/AssemblyCheck.fsproj index bb4b9dd2b7..78d2434988 100644 --- a/buildtools/AssemblyCheck/AssemblyCheck.fsproj +++ b/buildtools/AssemblyCheck/AssemblyCheck.fsproj @@ -7,7 +7,7 @@ - true + $(EnablePublishReadyToRun) $(NETCoreSdkRuntimeIdentifier) diff --git a/buildtools/fslex/fslex.fsproj b/buildtools/fslex/fslex.fsproj index 8efac3c7ab..5dfef2f0e3 100644 --- a/buildtools/fslex/fslex.fsproj +++ b/buildtools/fslex/fslex.fsproj @@ -8,7 +8,7 @@ - true + $(EnablePublishReadyToRun) $(NETCoreSdkRuntimeIdentifier) diff --git a/buildtools/fsyacc/fsyacc.fsproj b/buildtools/fsyacc/fsyacc.fsproj index c826ba5c5d..1ff8a11075 100644 --- a/buildtools/fsyacc/fsyacc.fsproj +++ b/buildtools/fsyacc/fsyacc.fsproj @@ -8,7 +8,7 @@ - true + $(EnablePublishReadyToRun) $(NETCoreSdkRuntimeIdentifier) diff --git a/eng/SourceBuild.props b/eng/SourceBuild.props index 3bfd9f80fc..8683870a8e 100644 --- a/eng/SourceBuild.props +++ b/eng/SourceBuild.props @@ -40,7 +40,7 @@ -bl enables the binlogs for the tools and Proto builds, which make debugging failures here easier --> diff --git a/eng/build.sh b/eng/build.sh index ab67c1ba62..e0a3348bfd 100755 --- a/eng/build.sh +++ b/eng/build.sh @@ -279,7 +279,7 @@ function BuildSolution { fi BuildMessage="Error building tools" - local args=" publish $repo_root/proto.proj $blrestore $bltools /p:Configuration=Proto /p:ArcadeBuildFromSource=$source_build" + local args=" publish $repo_root/proto.proj $blrestore $bltools /p:Configuration=Proto /p:ArcadeBuildFromSource=$source_build $properties" echo $args "$DOTNET_INSTALL_DIR/dotnet" $args #$args || exit $? fi diff --git a/src/fsc/fscProject/fsc.fsproj b/src/fsc/fscProject/fsc.fsproj index 1f22c8531e..889ece967a 100644 --- a/src/fsc/fscProject/fsc.fsproj +++ b/src/fsc/fscProject/fsc.fsproj @@ -10,7 +10,7 @@ $(FSharpNetCoreProductTargetFramework) - true + $(EnablePublishReadyToRun) $(NETCoreSdkRuntimeIdentifier) diff --git a/src/fsi/fsiProject/fsi.fsproj b/src/fsi/fsiProject/fsi.fsproj index 634ed56a9e..1b955f9564 100644 --- a/src/fsi/fsiProject/fsi.fsproj +++ b/src/fsi/fsiProject/fsi.fsproj @@ -10,7 +10,7 @@ $(FSharpNetCoreProductTargetFramework) - true + $(EnablePublishReadyToRun) $(NETCoreSdkRuntimeIdentifier)