From 6099d8ce3b558abefd7396a2d7970a557a16d09e Mon Sep 17 00:00:00 2001 From: Jimmy Byrd Date: Wed, 24 Apr 2024 09:05:27 -0400 Subject: [PATCH] Comments out signature file adjacency check in TransparentCompiler https://github.com/dotnet/fsharp/issues/17082 --- docs/release-notes/.FSharp.Compiler.Service/8.0.300.md | 1 + src/Compiler/Service/TransparentCompiler.fs | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/release-notes/.FSharp.Compiler.Service/8.0.300.md b/docs/release-notes/.FSharp.Compiler.Service/8.0.300.md index 045a18b0d75..e1d75f10bb1 100644 --- a/docs/release-notes/.FSharp.Compiler.Service/8.0.300.md +++ b/docs/release-notes/.FSharp.Compiler.Service/8.0.300.md @@ -28,6 +28,7 @@ * Enforce AttributeTargets on delegates ([PR #16891](https://github.com/dotnet/fsharp/pull/16891)) * Completion: fix completion in empty dot lambda prefix ([#16829](https://github.com/dotnet/fsharp/pull/16829)) * Fix StackOverflow when checking non-recursive bindings in module or namespace in `fscAnyCpu`/`fsiAnyCpu`. ([PR #16908](https://github.com/dotnet/fsharp/pull/16908)) +* Removes signature file adjacency check in Transparent Compiler [Issue #17082](https://github.com/dotnet/fsharp/issues/17082) [PR #17085](https://github.com/dotnet/fsharp/pull/17085) ### Added diff --git a/src/Compiler/Service/TransparentCompiler.fs b/src/Compiler/Service/TransparentCompiler.fs index 679c0d46d3f..183f03a22cc 100644 --- a/src/Compiler/Service/TransparentCompiler.fs +++ b/src/Compiler/Service/TransparentCompiler.fs @@ -1415,11 +1415,11 @@ type internal TransparentCompiler if tcInfo.stateContainsNodes |> Set.contains fileNode then failwith $"Oops!" - if - tcInfo.stateContainsNodes - |> Set.contains (NodeToTypeCheck.PhysicalFile(index + 1)) - then - failwith $"Oops!!!" + // if + // tcInfo.stateContainsNodes + // |> Set.contains (NodeToTypeCheck.PhysicalFile(index + 1)) + // then + // failwith $"Oops!!!" let parsedInput = projectSnapshot.SourceFiles[index].ParsedInput let prefixPathOpt = None