Removing already ported tests #15963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing an older merge conflict
psfinaki
approved these changes
Sep 12, 2023
0101
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an older merge conflict.
These tests were ported to Component.Tests as part of https://github.com/dotnet/fsharp/pull/14752/files#diff-db29528cb66ce3f978a3d345e9b2dbd6be899226aa303e6cfb5a554996504c47
However, they were added back as duplicates via a manual merge resolution in https://github.com/dotnet/fsharp/pull/14238/files#diff-753789c0c7d583cb168925ccd44e0eef6b1524af65f7ae25cb72739392429448 .
This PR makes sure we only execute them once && we do so in the in-process framework, gettign rid of the
tests.fsversion of them.