Skip to content

Parser: recover on unfinished accessors clause #15952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

Parser: recover on unfinished accessors clause #15952

merged 1 commit into from
Sep 12, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Sep 8, 2023

Adds recovery for unfinished accessors clauses in properties:

type T =
    abstract P: int with get,
type T =
    abstract P: int with
type T =
    member val P = 1 with get,
type T =
    member val P = 1 with

@auduchinok auduchinok requested a review from a team as a code owner September 8, 2023 13:21
@auduchinok
Copy link
Member Author

auduchinok commented Sep 8, 2023

And this is ready too. 🙂

TIHan
TIHan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

psfinaki
psfinaki approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Eugene!

@T-Gro T-Gro merged commit 1d96bdf into dotnet:main Sep 12, 2023
@allisonchou allisonchou mentioned this pull request Sep 14, 2023
Closed
@auduchinok auduchinok deleted the parser-getSet branch November 9, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@TIHan TIHan TIHan approved these changes

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok @TIHan @psfinaki @T-Gro