From 392b72037ec28b2da46818b55a95d69985070d1c Mon Sep 17 00:00:00 2001 From: Kevin Ransom Date: Fri, 1 Sep 2023 14:40:09 -0700 Subject: [PATCH 1/3] Reword policheck issue --- src/FSharp.Core/printf.fsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/FSharp.Core/printf.fsi b/src/FSharp.Core/printf.fsi index 6a2535892e7..a188e570183 100644 --- a/src/FSharp.Core/printf.fsi +++ b/src/FSharp.Core/printf.fsi @@ -28,7 +28,7 @@ type PrintfFormat<'Printer, 'State, 'Residue, 'Result> = /// Construct a format string /// The input string. /// The captured expressions in an interpolated string. - /// The types of expressions for %A holes in interpolated string. + /// The types of expressions for %A expression gaps in interpolated string. /// The PrintfFormat containing the formatted result. new: value: string * captures: obj[] * captureTys: Type[] -> PrintfFormat<'Printer, 'State, 'Residue, 'Result> @@ -65,7 +65,7 @@ type PrintfFormat<'Printer, 'State, 'Residue, 'Result, 'Tuple> = /// /// The input string. /// The captured expressions in an interpolated string. - /// The types of expressions for %A holes in interpolated string. + /// The types of expressions for %A expression gaps in interpolated string. /// /// The created format string. new: From f131a821792a05fafcebc3c6c0007e82155e0e12 Mon Sep 17 00:00:00 2001 From: Kevin Ransom Date: Fri, 1 Sep 2023 15:04:03 -0700 Subject: [PATCH 2/3] more policheck --- release-notes.md | 2 +- src/Compiler/Checking/CheckFormatStrings.fs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/release-notes.md b/release-notes.md index 5ba81c9ea38..ae01691ec3a 100644 --- a/release-notes.md +++ b/release-notes.md @@ -1118,7 +1118,7 @@ Contains commits from 32b124966 to d7018737c from dotnet/fsharp. Notable changes * lowered allocations for several internal compiler structures * better error messages for anonymous record mismatches * FSharpChecker learned how to keep background symbol uses -* Project cracker/project cracker tool were removed +* The tool for parsing projects was removed * Better support for consuming C# in-ref parameters * new services around simplifying names and finding unused declarations * package management in scripts (in preview) diff --git a/src/Compiler/Checking/CheckFormatStrings.fs b/src/Compiler/Checking/CheckFormatStrings.fs index ec52131c0f5..e32d073cbd1 100644 --- a/src/Compiler/Checking/CheckFormatStrings.fs +++ b/src/Compiler/Checking/CheckFormatStrings.fs @@ -187,7 +187,7 @@ module internal Parse = if p = None then None, fmtPos else p, pos' | _ -> None, fmtPos - // Explicitly typed holes in interpolated strings "....%d{x}..." get additional '%P()' as a hole place marker + // Explicitly typed expression gaps in interpolated strings "....%d{x}..." get additional '%P()' as an expression gap place marker let skipPossibleInterpolationHole isInterpolated isFormattableString (fmt: string) i = let len = fmt.Length if isInterpolated then From 7b8da6942038d33a9b1e7bb42d82521c8bbf370e Mon Sep 17 00:00:00 2001 From: Kevin Ransom Date: Fri, 1 Sep 2023 15:36:11 -0700 Subject: [PATCH 3/3] more policheck --- docs/debug-emit.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/debug-emit.md b/docs/debug-emit.md index 51e471a52f9..6ce5d471307 100644 --- a/docs/debug-emit.md +++ b/docs/debug-emit.md @@ -87,7 +87,7 @@ The intended debug points for constructs are determined by syntax as follows. P * The bodies of functions, methods, lambdas and initialization code for top-level-bindings are all processed as control flow -* Each CAPITAL-EXPR below is processed as control-flow (the bodies of loops, conditionals etc.) +* Each Upper-Cased EXPR below is processed as control-flow (the bodies of loops, conditionals etc.) * Leaf expressions are the other composite expressions like applications that are not covered by the other constructs.