Fix misleading naming in type checking logic #15768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@DedSec256 - that's valuable, thanks! Ping once you consider this ready, any testing to demo this would be great. |
DedSec256
changed the title
Contributor
Author
|
@psfinaki, I think this PR is ready. At the moment, I am finishing with work on adding ExtendedData for diagnostics (fsharp/fslang-suggestions#1094), and plan to open a PR in the near future. The corresponding tests are written there, in particular, for these exceptions. Some preview :) |
psfinaki
approved these changes
Aug 9, 2023
Contributor
|
Alright then - looking forward to the FS-1094 PR! |
edgarfgp
approved these changes
Aug 9, 2023
vzarytovskii
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions
ErrorFromAddingTypeEquationandErrorsFromAddingSubsumptionConstrainthaveexpectedTyandactualTyfields, but when they are created, the corresponding data is passed in reverse order.This PR fixes misleading naming in some sections of the code that lead to the creation of the aforementioned exceptions.