Skip to content

Implement completions for union case field names in patterns #15745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 16, 2023
Merged

Implement completions for union case field names in patterns #15745

merged 13 commits into from
Aug 16, 2023

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Aug 3, 2023

devenv_3LbH2w0jKa

Unfortunately, VS does its own sorting, so when these items are not the only thing on the list, they might be buried deep.

devenv_a67wgbdqL3

@kerams kerams requested a review from a team as a code owner August 3, 2023 16:17
@kerams kerams changed the title Implement completions for union case fields in patterns Implement completions for union case field names in patterns Aug 3, 2023
@kerams kerams marked this pull request as draft August 4, 2023 16:25
@kerams
Copy link
Contributor Author

kerams commented Aug 5, 2023

#15754 needs to go first.

@kerams kerams marked this pull request as ready for review August 8, 2023 16:19
@kerams
Copy link
Contributor Author

kerams commented Aug 8, 2023

I had to fix the range of SynPat.LongIndent when it takes named pat pairs and there's a redundant semicolon at the end - the range stops at the semicolon instead of the rparen. The parsing code around atomicPatsOrNamePatPairs is ever so slightly simpler now.

cc @auduchinok

kerams
kerams commented Aug 8, 2023
View reviewed changes
@kerams
Copy link
Contributor Author

kerams commented Aug 10, 2023

The CI is gunted. Otherwise ready.

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 16, 2023 09:28
@vzarytovskii
Copy link
Member

vzarytovskii commented Aug 16, 2023

@dotnet/fsharp-team-msft can I get a second approval pls?

psfinaki
psfinaki approved these changes Aug 16, 2023
View reviewed changes
auto-merge was automatically disabled August 16, 2023 13:25

Head branch was pushed to by a user without write access

@psfinaki psfinaki enabled auto-merge (squash) August 16, 2023 13:59
@psfinaki psfinaki merged commit c9ad8e3 into dotnet:main Aug 16, 2023
@kerams kerams deleted the f branch August 16, 2023 14:18
@allisonchou allisonchou mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+2 more reviewers

@auduchinok auduchinok auduchinok left review comments

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.8

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kerams @vzarytovskii @auduchinok @psfinaki