Skip to content

Fixing code fixes, part 5 #15663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 31, 2023
Merged

Fixing code fixes, part 5 #15663

merged 11 commits into from
Jul 31, 2023

Conversation

@psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Jul 21, 2023 •
edited
Loading

This PR focuses on our bulk code fixes, six out of nine. They are rewritten, extended, fixed, tested.

In particular, the PR:

This PR does not address unused parameters, signature files, code fixes related to the IDE diags. Next time.

@psfinaki psfinaki requested a review from a team as a code owner July 21, 2023 20:40
@psfinaki
Copy link
Contributor Author

psfinaki commented Jul 22, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 22, 2023

Azure Pipelines successfully started running 2 pipeline(s).

vzarytovskii
vzarytovskii reviewed Jul 24, 2023
View reviewed changes
vzarytovskii
vzarytovskii reviewed Jul 24, 2023
View reviewed changes
vzarytovskii
vzarytovskii reviewed Jul 24, 2023
View reviewed changes
T-Gro
T-Gro reviewed Jul 25, 2023
View reviewed changes
vzarytovskii
vzarytovskii reviewed Jul 25, 2023
View reviewed changes
T-Gro
T-Gro reviewed Jul 25, 2023
View reviewed changes
@psfinaki psfinaki enabled auto-merge (squash) July 28, 2023 17:43
@psfinaki psfinaki merged commit 6838eab into dotnet:main Jul 31, 2023
@psfinaki psfinaki deleted the codefixes-18 branch July 31, 2023 14:45
@psfinaki psfinaki mentioned this pull request Jul 31, 2023
Open
@psfinaki psfinaki mentioned this pull request Jul 31, 2023
Open
@allisonchou allisonchou mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

4 participants

@psfinaki @vzarytovskii @KevinRansom @T-Gro