Skip to content

More accurate range for FS0053: Discriminated union cases and exception labels must be uppercase identifiers #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2023
Merged

More accurate range for FS0053: Discriminated union cases and exception labels must be uppercase identifiers #15545

merged 2 commits into from
Jul 4, 2023

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jul 4, 2023 •
edited by psfinaki
Loading

Fixes #15507

Update: also fixes #15509

@edgarfgp edgarfgp marked this pull request as ready for review July 4, 2023 16:24
@edgarfgp edgarfgp requested a review from a team as a code owner July 4, 2023 16:24
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Jul 4, 2023

This is ready

psfinaki
psfinaki approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two birds with one stone!

Thanks @edgarfgp, you've made my day :)

@psfinaki psfinaki enabled auto-merge (squash) July 4, 2023 18:16
@psfinaki psfinaki merged commit 723b1dc into dotnet:main Jul 4, 2023
@allisonchou allisonchou mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement ProposeUppercaseLabel code fix for lowercase exceptions Probably inconsistent error range for FS0053

3 participants

@edgarfgp @psfinaki @T-Gro