Skip to content

Parser: recover on unfinished nested modules #15402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2023
Merged

Parser: recover on unfinished nested modules #15402

merged 3 commits into from
Jun 19, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Jun 15, 2023 •
edited
Loading

Various unfinished nested module cases:

namespace Ns

module
namespace Ns

module rec
namespace Ns

module A
namespace Ns

module A =

Recovery for subsequent declarations is possible due to the new rules:

namespace Ns

module A =

module B =
    ()

@auduchinok auduchinok requested a review from a team as a code owner June 15, 2023 10:31
T-Gro
T-Gro reviewed Jun 15, 2023
View reviewed changes
T-Gro
T-Gro reviewed Jun 15, 2023
View reviewed changes
@auduchinok auduchinok force-pushed the parser-nestedModule branch 2 times, most recently from 54666eb to ccb781e Compare June 15, 2023 15:46
@auduchinok
Copy link
Member Author

auduchinok commented Jun 15, 2023

This is ready.

@auduchinok auduchinok requested a review from T-Gro June 16, 2023 14:48
@auduchinok auduchinok force-pushed the parser-nestedModule branch from a22dad7 to f85d8cb Compare June 19, 2023 09:50
@vzarytovskii vzarytovskii merged commit db4dbc1 into dotnet:main Jun 19, 2023
@auduchinok auduchinok deleted the parser-nestedModule branch June 19, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok @vzarytovskii @T-Gro