Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Jun 13, 2023

For a symbol for WriteJson in override this.WriteJson(writer, value, serializer) = failwith "todo"

GetValSignatureText would return

JsonConverter.WriteJson(writer: obj, value: obj, serializer: obj) : unit,

after this PR it returns override WriteJson: writer: obj * value: obj * serializer: obj -> unit

I'll need to see if CI agrees with the override keyword change.

@nojaf nojaf requested a review from a team as a code owner June 13, 2023 07:26
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants