Skip to content

Conversation

@psfinaki
Copy link
Contributor

I am making code fixes great again, so that they are easy to write and to test.

This PR is the first step with the scope of 3 random code fixes. The changes include the following:

  1. Adding some basic testing framework
  2. Adding some tests
  3. Adjusting the code in the code fixes
  4. Rewriting asyncMaybe to cancellableTask
  5. Fixing recently introduced Convert To Anonymous Record code fix is broken #15372 discovered along the way, to prove this all makes sense :)

Apart from fixing the bug, the code is left untouched as much as possible within the changed monads.

We'll see where things go - so this doesn't aim for perfection, other code fixes might required adjustments in the testing framework.

@psfinaki psfinaki requested a review from a team as a code owner June 12, 2023 20:09
@psfinaki psfinaki linked an issue Jun 12, 2023 that may be closed by this pull request
@psfinaki psfinaki requested a review from T-Gro June 13, 2023 12:38
@psfinaki psfinaki enabled auto-merge (squash) June 14, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Convert To Anonymous Record code fix is broken

4 participants