Skip to content

Conversation

@KevinRansom
Copy link
Contributor

In my never-ending quest to improve testing here, I have re-arranged the FSharp.Compiler.ComponentTests test suite somewhat.

I have:

  1. Shrunk the namespaces so that the first 2/3's of the screen is taken up with exactly the same text for every test category.
  2. Reduced the number of top level categories by merging them, where it made sense to.

I expect this to improve the experience of running tests in VS, and probably VSCode at least a little bit. If we decide this is a decent improvement we can consider expanding it to some of the other suites.

Here is a before and after of the VS TestExplorer for ComponentTests:

image

@KevinRansom KevinRansom requested a review from a team as a code owner June 9, 2023 06:34
@KevinRansom KevinRansom added this to the June-2023 milestone Jun 9, 2023
@T-Gro
Copy link
Member

T-Gro commented Jun 9, 2023

Which were the actions taken please?

As far as I can see:

  • Find "Fsharp.Compiler.ComponentTests." replaceWith ""
  • Find test method with . replaceWith test method with _ (since . causes a new node in test explorer, even when part of method name)
  • Consistent casing (e.g. fsc -> Fsc)

Any other?

@T-Gro
Copy link
Member

T-Gro commented Jun 9, 2023

Why is "Conformance" not a separate node with the children beneath, is it because of namespace vs. module approach we use across the test suite?

@KevinRansom KevinRansom enabled auto-merge (squash) June 9, 2023 16:45
@KevinRansom
Copy link
Contributor Author

Which were the actions taken please?

As far as I can see:

  • Find "Fsharp.Compiler.ComponentTests." replaceWith ""
  • Find test method with . replaceWith test method with _ (since . causes a new node in test explorer, even when part of method name)
  • Consistent casing (e.g. fsc -> Fsc)

Any other?

@T-Gro -- Plus moving some tests into other groups to compress them, and removing and refactoring a couple of small modules. Yes.

@KevinRansom
Copy link
Contributor Author

KevinRansom commented Jun 9, 2023

Why is "Conformance" not a separate node with the children beneath, is it because of namespace vs. module approach we use across the test suite?

Yes it would be nice if the nodes could split on namespaces, but I believe the test hierarchy is:

Assembly
      Full namespace
             Typename
                    Common leading portion of namespace name
                                Full testcase namespace name

@KevinRansom KevinRansom merged commit 7994fd7 into dotnet:main Jun 9, 2023
@KevinRansom KevinRansom deleted the reorganisecomponenttests branch March 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants