Fix Attribute Serialization #15152
Merged
Fix Attribute Serialization #15152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
fixattributeserialization
branch
from
b15a2b5 to
f99deb3
Compare
KevinRansom
force-pushed
the
fixattributeserialization
branch
from
f99deb3 to
68372c6
Compare
T-Gro
reviewed
May 2, 2023
...sts/Conformance/DeclarationElements/CustomAttributes/Basic/EnsureValidCustomAttributeBlob.fs
Show resolved
Hide resolved
T-Gro
reviewed
May 2, 2023
tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
Outdated
Show resolved
Hide resolved
T-Gro
approved these changes
May 2, 2023
abonie
approved these changes
May 2, 2023
Remove vs added line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15140
F# Attribute blob serialization for open generics created an invalid blob. This addresses that issue.
The fix is to use typdefof, which serializes correctly for open generics.
Todo: