-
Notifications
You must be signed in to change notification settings - Fork 830
Fixing Bulk codefix (Removed unused opens) + adding new ones in Bulk mode #15082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/run fantomas |
Co-authored-by: T-Gro <[email protected]>
Contributor
vzarytovskii
approved these changes
Apr 16, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
psfinaki
suggested changes
Apr 17, 2023
psfinaki
reviewed
Apr 17, 2023
psfinaki
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes are now available in bulk document/project/solution mode.
The selection was done subjectively my thinking which kind of diagnostical errors can easily accumulate over a codebase (e.g. after a refactoring, or when updating language version) and where the benefit of a bulk fix exists.
There is no guarantee that other codefixes wouldnt benefit from bulk mode massively as well - if you think of any, let me know and such can be added later as well.
Telemetry reporting in it's previous form would not work for the bulk operation.
The codefixers have explicit telemetry reporting, on the level of 1 event per document in bulk operatios (as opposed to 1 event per each occurrence normally)