Skip to content

Don't check the unfinished expression before dot as the whole expression #14801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2023
Merged

Don't check the unfinished expression before dot as the whole expression #14801

merged 2 commits into from
Feb 27, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Feb 24, 2023

A continuation of #14718. It turned out, it got broken back when I tried to fix the tests, since LongOrSingleIdent is also used in TcExprThen.

Adds a recovery test.

@auduchinok auduchinok requested a review from a team as a code owner February 24, 2023 10:40
KevinRansom
KevinRansom approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vzarytovskii vzarytovskii merged commit d415ef9 into dotnet:main Feb 27, 2023
@auduchinok auduchinok deleted the tc-mkSynDotMissing2 branch February 27, 2023 15:54
@allisonchou allisonchou mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok @vzarytovskii @KevinRansom