Refactor component test compilation #14747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
testdriver
branch
from
1b13d00 to
77e57d4
Compare
Comment on lines
+128
to
+140
| /Z.fs | ||
| /Y.fs | ||
| /X.fs | ||
| /Library.fs | ||
| /Ghost.fs | ||
| /D.fsi | ||
| /D.fs | ||
| /C.fsi | ||
| /C.fs | ||
| /B.fsi | ||
| /B.fs | ||
| /A.fsi | ||
| /A.fs |
vzarytovskii
approved these changes
Feb 15, 2023
| let systemDynamicRuntimeRef = lazy AssemblyMetadata.CreateFromImage(TestResources.NetFX.netstandard20.System_Dynamic_Runtime).GetReference(display = "System.Dynamic.Runtime.dll (netstandard 2.0 ref)") | ||
|
|
||
|
|
||
| module private NetCoreApp31Refs = |
Member
There was a problem hiding this comment.
Do we still use netcoreapp31 somewhere?
| let asNetStandard20 (cUnit: CompilationUnit) : CompilationUnit = | ||
| match cUnit with | ||
| | FS fs -> FS { fs with TargetFramework = TargetFramework.NetStandard20 } | ||
| | CS cs -> CS { cs with TargetFramework = TargetFramework.NetStandard20 } |
Member
There was a problem hiding this comment.
Curious - does it work with C# tests too?
Contributor
Author
There was a problem hiding this comment.
not yet, when I need it for C# I will make it work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the TargetFramework for compilation in the test framework to be configured.
It is necessary because the current mechanism uses #if/#else/#endif to hard code the framework references based on the TFM of the test build. However, we should be able to compile other tfms for example Netstandard2.0