Refactor ResolveLongIdentAsModuleOrNamespace #14661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerams
commented
Jan 25, 2023
kerams
commented
Jan 25, 2023
psfinaki
approved these changes
Jan 26, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Thanks for this @kerams.
As for removing the parameter - is there any potential backward compat issue @vzarytovskii?
Member
|
It's internal, so we should be fine with changing it |
T-Gro
approved these changes
Jan 26, 2023
Contributor
|
@kerams feel free to resolve the comments and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the names of a couple of values as well as removed an unnecessary list creation.
The
(atMostOne: ResultCollectionSettings)parameter to the function is currently not used for anything, so I could remove it if you want.