Remove dependence on microsoft.build from FCS #14341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Where should an explanation towards FCS users go? Release notes / docs ? |
T-Gro
approved these changes
Nov 18, 2022
psfinaki
approved these changes
Nov 18, 2022
auduchinok
reviewed
Mar 9, 2023
Comment on lines
+1
to
+4
| # ------------------------------------------------------------------------------- | ||
| # use a completely new error number and keep messages in their surrounding groups | ||
| # ------------------------------------------------------------------------------- | ||
| assemblyResolutionFoundByAssemblyFoldersKey,"Found by AssemblyFolders registry key" |
Member
There was a problem hiding this comment.
@KevinRansom Is there a chance these numbers could clash with other FCS ones? How these numbers are going to be accessed via FSharpDiagnostic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the msbuild dependency to be the responsibility of fcs clients.