Skip to content

TypeDefn and NamespaceOrModule leading trivia #14126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 19, 2022
Merged

TypeDefn and NamespaceOrModule leading trivia #14126

merged 7 commits into from
Oct 19, 2022

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 17, 2022

This streamlines a couple of the previous trivia captures.
For example, you cannot both have the module and namespace keywords at the same time.

@T-Gro T-Gro merged commit 7d115d5 into dotnet:main Oct 19, 2022
@nojaf nojaf deleted the and-type-trivia branch October 19, 2022 07:21
@allisonchou allisonchou mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme approved these changes

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.5

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nojaf @0101 @dsyme @T-Gro @vzarytovskii