fix script editing perf #10159
Merged
fix script editing perf #10159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Sep 19, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
This looks like it will help a lot. I'm sorry you don't like old-school type annotations though :-)
Contributor
|
@dsyme also confirmed that renaming doesn't hose the script, which is great since that was one of the motivators behind the big work done in this area in VS 2019. |
This was
linked to
issues
Sep 19, 2020
cartermp
approved these changes
Sep 19, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Don Syme <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Co-authored-by: Don Syme <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Co-authored-by: Don Syme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three script editing perf issues in Visual Studio
Slow down in Visual Studio Preview with Package references for F# scripts
The processing of dependency resolutions is now cached in dependency providers. Editing scripts containing #r "nuget..." is now respectably fast.
A lot of processing still happens when preparing project options but because of 2 & 3 this happens in the background.
Use of CSVProvider with inferRows leads to UI delays
This is because operations related to pasting and formatting of code which are running on the UI thread (or synchronizing with it) were requiring precise options for scripts. This is not necessary in practice for such simple operations requiring only the parsing options, which are going to be available as a result of background requests.
Pasting and hitting "return" in scripts with complex
#loaddependencies could take a long time. Again this is because operations running on the UI thread were requiring precise options for scripts., see FSharpSynchronousIndentationService is, well, UI synchronous #10156The fix also threads better userOpName diagnostics information through FSharp.Editor (so the FCS reactor logging shows what user operation is causing the long pauses on the reactor thread)