Mutable fields --- Fixes #10021 --- fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok #10116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Sep 13, 2020
vzarytovskii
approved these changes
Sep 14, 2020
dsyme
changed the title
KevinRansom
added a commit
that referenced
this pull request
Sep 14, 2020
* Bloody mutable fields (#10116) * Fix 9150 --- #i nuget on desktop witout net48 ref assemblies fails. (#10114) * signing (#10108) Co-authored-by: Kevin Ransom (msft) <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Bloody mutable fields (dotnet#10116) * Fix 9150 --- #i nuget on desktop witout net48 ref assemblies fails. (dotnet#10114) * signing (dotnet#10108) Co-authored-by: Kevin Ransom (msft) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug caused by mutable state.
loader reqd.AssemblyName may cause the entry for reqd.AssemblyName to be fixed up, if the reference was provided using --reference.
So before we try to fix up the entry we re-check to see if the ccuthunk has already been fixed up.
Kevin