"Open declaration can be removed" - but actually it cannot

[forki]

Repro steps

1. clone https://github.com/fsprojects/Canopy.Mobile
2. run paket restore
3. open sln in VS2017
4. open Canopy.Mobile.fs

If you accept then you get compile errors

Expected behavior

Don't show the suggestion

/cc @vasily-kirichenko

[vasily-kirichenko]

Why it cannot be removed?

[forki]

because then compile errors happen

[forki]

it's a false postive

[matthid]

@forki I guess @vasily-kirichenko is asking for the compiler error or the statement which needs the open ;)

[forki]

typical name resolutions issues.

[vasily-kirichenko]

No, I'm asking for the source code of a symbol that makes the open statement needed.

[vasily-kirichenko]

(I guess it's the exception definition)

[forki]

see screenshot

[forki]

    /// Contains canopy specific exception
    module canopy.mobile.Exceptions

    open System

    type CanopyException(message) = inherit Exception(message)
    type CanopyElementNotFoundException(message) = inherit CanopyException(message)

^^ is the other file

[vasily-kirichenko]

Thanks.

[vasily-kirichenko]

Ah, relative opens. They are not supported. Use full ns/module names.

[forki]

What do you mean they are not supported? That's proper F# - the tooling should adjust and not my code, right? If there is no way to make it work with relative opens then it should be disabled for relative opens, right?

Also not that open Wait is not greyed out

[vasily-kirichenko]

Right :) The problem is that opens are not symbols, they are text from untyped AST. However, if it works properly for Wait, it maybe the case that exceptions are not processed.

[vasily-kirichenko]

Sorry, Ctrl+F5 crashes VS immediately on my machine :))

[dsyme]

What do you mean they are not supported? That's proper F# - the tooling should adjust and not my code, right? If there is no way to make it work with relative opens then it should be disabled for relative opens, right?

Perhaps a code fix to turn relative opens into fully-qualified opens.