RemoveUnusedBinding code fix doesn't remove class identifiers

[psfinaki]

Demo:

asthis.mp4

Code:

type Animal(name:string) =
    member val Name = name with get, set

type Dog(name:string) as this = 
    inherit Animal(name)

    member this.Bark() =
        printfn "%s says Woof!" this.Name

[psfinaki]

So, this is an interesting case. Actually, there are two diags reported for this:

• FS1182 - the value is unused
• FS1183 - The recursive object reference 'this' is unused. The presence of a recursive object reference adds runtime initialization checks to members in this and derived types. Consider removing this recursive object reference.

The code fix itself currently reacts to the FS1182. But it's not working then. There are two ways to go:

• address this case for FS1182 - then this is partially blocked by FS1182 doesn't produce warnings for class members even being in WarnOn #15636 (hard to test)
• add FS1183 as a trigger for this code fix - complicates matters a bit but doable