fix incomplete match location for some expressions (#12897)

* fix match location

* fix baseline

* fix

Author: dsyme

src/fsharp/CheckExpressions.fs

@@ -5842,7 +5842,7 @@ and TcExprUndelayed cenv (overallTy: OverallTy) env tpenv (synExpr: SynExpr) =
         let inputExpr, inputTy, tpenv =
             let env = { env with eIsControlFlow = false }
             TcExprOfUnknownType cenv env tpenv synInputExpr
-        let mInputExpr = inputExpr.Range
+        let mInputExpr = synInputExpr.Range
         let env = { env with eIsControlFlow = true }
         let matchVal, matchExpr, tpenv = TcAndPatternCompileMatchClauses mInputExpr mInputExpr ThrowIncompleteMatchException cenv (Some inputExpr) inputTy overallTy env tpenv synClauses
         let overallExpr = mkLet spMatch mInputExpr matchVal inputExpr matchExpr

tests/FSharp.Compiler.ComponentTests/Conformance/LexicalFiltering/OffsideExceptions/RelaxWhitespace2.fs.err.bsl

@@ -41,7 +41,7 @@ RelaxWhitespace2.fs (2742,9)-(2744,13) typecheck warning Incomplete pattern matc
 RelaxWhitespace2.fs (3391,13)-(3391,14) typecheck warning Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
 RelaxWhitespace2.fs (3394,13)-(3394,14) typecheck warning Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
 RelaxWhitespace2.fs (3397,13)-(3397,14) typecheck warning Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
-RelaxWhitespace2.fs (3403,21)-(3403,22) typecheck warning Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
+RelaxWhitespace2.fs (3401,13)-(3406,21) typecheck warning Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
 RelaxWhitespace2.fs (3410,13)-(3415,20) typecheck warning Incomplete pattern matches on this expression. For example, the value '0' may indicate a case not covered by the pattern(s).
 RelaxWhitespace2.fs (3713,1)-(3713,9) typecheck warning Incomplete pattern matches on this expression. For example, the value '{ y=0 }' may indicate a case not covered by the pattern(s).
 RelaxWhitespace2.fs (3720,1)-(3720,9) typecheck warning Incomplete pattern matches on this expression.

tests/fsharp/typecheck/sigs/neg102.bsl

@@ -16,3 +16,5 @@ neg102.fs(32,14,32,22): typecheck error FS0104: Enums may take values outside kn
 neg102.fs(37,14,37,22): typecheck error FS0104: Enums may take values outside known cases. For example, the value 'Some (enum<EnumABC> (2))' may indicate a case not covered by the pattern(s).
 
 neg102.fs(44,14,44,22): typecheck error FS0104: Enums may take values outside known cases. For example, the value 'enum<System.DateTimeKind> (3)' may indicate a case not covered by the pattern(s).
+
+neg102.fs(51,15,55,10): typecheck error FS0025: Incomplete pattern matches on this expression. For example, the value 'Some (_)' may indicate a case not covered by the pattern(s).

tests/fsharp/typecheck/sigs/neg102.fs

@@ -45,3 +45,13 @@ module FS0104 =
         | System.DateTimeKind.Unspecified -> "Unspecified"
         | System.DateTimeKind.Utc -> "Utc"
         | System.DateTimeKind.Local -> "Local"
+
+module IncompleteMatchWarningAtRightPlace =
+    let f() =
+        match (
+            let value = 5
+            value + 4
+            |> Some
+        )
+        with
+        | None -> ()

tests/fsharp/typecheck/sigs/neg102.vsbsl

@@ -16,3 +16,5 @@ neg102.fs(32,14,32,22): typecheck error FS0104: Enums may take values outside kn
 neg102.fs(37,14,37,22): typecheck error FS0104: Enums may take values outside known cases. For example, the value 'Some (enum<EnumABC> (2))' may indicate a case not covered by the pattern(s).
 
 neg102.fs(44,14,44,22): typecheck error FS0104: Enums may take values outside known cases. For example, the value 'enum<System.DateTimeKind> (3)' may indicate a case not covered by the pattern(s).
+
+neg102.fs(51,15,55,10): typecheck error FS0025: Incomplete pattern matches on this expression. For example, the value 'Some (_)' may indicate a case not covered by the pattern(s).

tests/service/PatternMatchCompilationTests.fs

@@ -457,7 +457,7 @@ match Unchecked.defaultof<int> with
 """
     assertHasSymbolUsages ["a"] checkResults
     dumpErrors checkResults |> shouldEqual [
-        "(2,6--2,25): Incomplete pattern matches on this expression. For example, the value '``some-other-subtype``' may indicate a case not covered by the pattern(s)."
+        "(2,6--2,30): Incomplete pattern matches on this expression. For example, the value '``some-other-subtype``' may indicate a case not covered by the pattern(s)."
         "(6,2--6,6): The type 'int' does not have any proper subtypes and cannot be used as the source of a type test or runtime coercion."
     ]